Repository navigation
fix calculation of dimming surplus - #3362
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how “dimming surplus” is calculated for controllable-consumer dimming via IO, and simplifies the setup logic by always factoring the computed surplus into the available import power limit.
Changes:
- Introduces
calc_dimming_surplus()to derive surplus from PV and battery power values. - Updates
setup()to use the new surplus calculation and simplifies the import-power-left computation. - Enhances debug logging to include both the surplus and the remaining dimming power.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
benderl
approved these changes
May 12, 2026
benderl
left a comment
benderl
left a comment
Contributor
There was a problem hiding this comment.
Mit Simulator erfolgreich getestet!
ndrsnhs
pushed a commit
to ndrsnhs/core
that referenced
this pull request
Aug 24, 2026
* fix calculation of dimming surplus * fix * improve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.