Repository navigation
fix bat set controllability - #3372
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates battery controllability handling so controllable and non-controllable battery components are tracked separately and used when setting battery power limits.
Changes:
- Replaces
get_controllable_bat_components()withget_bat_components_by_controllability(). - Updates battery state propagation for controllable and non-controllable batteries.
- Adjusts related battery control tests to mock the new helper return shape.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/control/bat_all.py |
Adds controllability grouping and updates battery control logic to use it. |
packages/control/process.py |
Uses the controllable component list when dispatching battery power limit writes. |
packages/control/bat_all_test.py |
Updates mocks for the renamed/helper return signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| bat_components.append(comp_value) | ||
| return bat_components | ||
| with SingleComponentUpdateContext(comp_value.fault_state, update_always=False): | ||
| if comp_value.power_limit_controllable(): |
ndrsnhs
pushed a commit
to ndrsnhs/core
that referenced
this pull request
Aug 24, 2026
* fix bat set controlllablitity * review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.