Repository navigation
Feature kostal steca inverter http retry - #3388
Merged
LKuemmel merged 3 commits intoJun 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Ergänzt HTTP-Retries für die Kostal/Steca-Inverter-Abfragen, um wiederkehrende HTTP-Timeouts (ca. alle 1–2 Stunden) robuster abzufangen.
Changes:
- Nutzt eine gemeinsame HTTP-Session pro
get_values()-Aufruf (statt mehrere einzelne Requests ohne Session-Wiederverwendung). - Konfiguriert Timeout über
session.default_timeoutund aktiviert Retries viaHTTPAdapter(max_retries=2).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8
to
10
| from requests.adapters import HTTPAdapter | ||
|
|
||
| from modules.common import req |
Contributor
Author
There was a problem hiding this comment.
IMHO it's a matter of taste if you want to be more explicit at the expense of verbosity. Can the openWB SW team please decide?
Comment on lines
+53
to
+55
| session.default_timeout = 2 | ||
| session.mount("http://", HTTPAdapter(max_retries=2)) | ||
| # call for XML file and parse it for current PV power |
Contributor
Author
There was a problem hiding this comment.
IMHO it's a matter of taste if you want to be more explicit at the expense of verbosity. Can the openWB SW team please decide?
Contributor
Author
|
Can the openWB SW team please decide whether the changes suggested by Copilot should be adopted? |
Contributor
|
Deine Änderungen ist ok so. |
ndrsnhs
pushed a commit
to ndrsnhs/core
that referenced
this pull request
Aug 24, 2026
* Introduce session and retries for http * Reduce retries * Increase retries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wegen zahlreicher http-Timeouts (alle 1 bis 2 Stunden) Retries mit maximal 2 Retry-Versuchen ergänzt.