Repository navigation
energy charts: net/brutto and tax field - #3394
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for Energy-Charts flexible tariff pricing to distinguish net vs. gross prices by applying a configurable VAT/tax factor, and migrates existing configurations to include the new fields.
Changes:
- Extend
EnergyChartsTariffConfigurationwithnetandtaxfields (defaults: net, 19%). - Apply
taxwhennet=Falsewhile converting Energy-Charts API prices. - Add a datastore migration (v124) to backfill missing
net/taxfor existing Energy-Charts provider configs, plus unit tests for net/gross parsing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/modules/electricity_pricing/flexible_tariffs/energycharts/tariff.py | Applies VAT/tax multiplier when configured for gross prices. |
| packages/modules/electricity_pricing/flexible_tariffs/energycharts/config.py | Adds net/tax config parameters with defaults. |
| packages/modules/electricity_pricing/flexible_tariffs/energycharts/tariff_test.py | Adds tests covering net prices and gross prices with tax. |
| packages/helpermodules/update_config.py | Bumps datastore version to 124 and migrates Energy-Charts provider configs to include net/tax. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -27,7 +27,10 @@ def create_request_url(config: EnergyChartsTariffConfiguration) -> str: | |||
| def parse_response(config: EnergyChartsTariffConfiguration, raw_prices: dict) -> Dict[str, float]: | |||
| prices: Dict[int, float] = {} | |||
LKuemmel
force-pushed
the
electricity_tariff
branch
from
June 9, 2026 09:43
4ccd6c5 to
fdfc4da
Compare
ndrsnhs
pushed a commit
to ndrsnhs/core
that referenced
this pull request
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openWB/openwb-ui-settings#988
https://forum.openwb.de/viewtopic.php?p=143726#p143726