Repository navigation
Solis-S Series: Fix bat_power direction - #3583
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the sign/direction of Solis S-series battery power reporting by deriving the sign from Modbus register 33135, since the battery power register provides only the magnitude.
Changes:
- Adjust battery current scaling to be unsigned (
* 0.1) and apply sign based on direction register33135. - Apply the same direction-based sign correction to battery power (
33149) to align charging/discharging sign semantics.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LKuemmel
approved these changes
Jun 23, 2026
ndrsnhs
added a commit
to ndrsnhs/core
that referenced
this pull request
Aug 24, 2026
* read power direction * remove whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket #66005578
Register der Speicherleistung liefert nur den Betrag. Vorzeichen steht in Reg 33135.