Repository navigation
usage type self controlled - #3775
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new consumer usage type (self_controlled) to support consumers that are not directly controlled by openWB but instead receive current system values (e.g., PV, grid, battery) via MQTT for self-managed behavior.
Changes:
- Added
self_controlledto the consumer usage type model (UI + backend enum/config). - Updated control flow to treat
self_controlledas “not controlled” and to send aggregatedCurrentValuesto the consumer module when configured. - Extended MQTT consumer module + setdata validation to support publishing/accepting the new value topics (
bat_power,bat_soc,cp_power,evu_power,home_consumption,pv_power) and adjusted UI visibility for mode controls.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/modules/web_themes/koala/source/src/stores/mqtt-store-model.ts | Adds self_controlled to the UI-level consumer usage type union. |
| packages/modules/web_themes/koala/source/src/components/ConsumerSettings.vue | Hides mode controls for self_controlled consumers. |
| packages/modules/web_themes/koala/source/src/components/ConsumerCard.vue | Treats self_controlled similarly to meter_only in the card UI logic. |
| packages/modules/consumers/generic/mqtt/consumer.py | Adds send_values() to publish aggregated values for self-controlled consumers. |
| packages/modules/consumers/generic/mqtt/config.py | Enables SELF_CONTROLLED as a supported usage for the generic MQTT consumer module. |
| packages/modules/common/configurable_consumer.py | Extends ConfigurableConsumer with a send_values(CurrentValues) callback pathway. |
| packages/modules/common/abstract_consumer.py | Introduces CurrentValues dataclass used for passing aggregated values. |
| packages/helpermodules/setdata.py | Expands topic validation for new MQTT consumer set-topics and adds validation for id-less consumer fault topics. |
| packages/control/process.py | Sends CurrentValues via consumer.module.send_values() when usage is SELF_CONTROLLED. |
| packages/control/consumer/usage.py | Adds SELF_CONTROLLED enum value and NOT_CONTROLLED grouping constant. |
| packages/control/consumer/consumer.py | Uses NOT_CONTROLLED to skip control logic for meter_only and self_controlled. |
| packages/control/consumer/consumer_data.py | Refactors dataclass defaults (and removes unused nested log dataclass). |
| docs/samples/sample_consumer/sample_consumer/consumer.py | Documents how to implement send_values() for a self-controlled consumer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -24,13 +25,15 @@ def __init__(self, | |||
| initializer: Optional[Callable] = lambda: None, | |||
| error_handler: Optional[Callable] = lambda: None, | |||
| update: Optional[Callable[[], ConsumerState]] = lambda: None, | |||
| send_values: Optional[Callable[[CurrentValues], None]] = lambda: None, | |||
Comment on lines
125
to
127
| const meterOnly = computed( | ||
| () => mqttStore.consumerUsageType(props.consumerId) === 'meter_only', | ||
| () => mqttStore.consumerUsageType(props.consumerId) === 'meter_only' || mqttStore.consumerUsageType(props.consumerId) === 'self_controlled', | ||
| ); |
Comment on lines
+200
to
+202
| return Thread(target=consumer.module.send_values, | ||
| args=(current_values,), | ||
| name=f"set current consumer{consumer.num}") |
LKuemmel
added a commit
that referenced
this pull request
Aug 18, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
that referenced
this pull request
Aug 18, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
that referenced
this pull request
Aug 19, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
that referenced
this pull request
Aug 19, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
that referenced
this pull request
Aug 20, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
that referenced
this pull request
Aug 20, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
that referenced
this pull request
Aug 20, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
that referenced
this pull request
Aug 21, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
that referenced
this pull request
Aug 24, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
that referenced
this pull request
Aug 26, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
that referenced
this pull request
Aug 28, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
that referenced
this pull request
Sep 7, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
to benderl/core
that referenced
this pull request
Sep 8, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
that referenced
this pull request
Sep 9, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
that referenced
this pull request
Sep 9, 2026
* usage type self controlled * fix * review
LKuemmel
added a commit
that referenced
this pull request
Sep 9, 2026
* draft * draft * fixes * fixes * Anlauferkennung, Betriebsmodus zurücksetzen, Befehle für Pläne (#3588) * draft * Anlauferkennung * Betriebsmodus zurücksetzen * ammend * Anlauferkennung * draft * draft scheduled charging * add scheduled und time plan commands for adding and removing * flake8 * update config * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <[email protected]> * review * fix pytest --------- Co-authored-by: Copilot Autofix powered by AI <[email protected]> * on time, fixes (#3612) * on_time * eco default price, typo * on_time accessible via 1883 (#3626) * on_time accessible via 1883 * fix * Add Consumer tab and cards to koala web theme (#3630) * add consumer tab/cards * apply new design to consumer cards * add consumer time on to consumer card * fix consumer card CSS * remove redundant placeholders * imported and exported for consumers; daily, monthly log; daily yields; graph data (#3644) * update module config * imported and exported for consumers * daily, monthly log * daily yields * graph data * Consumer cards in carousel - small screen mobile view (#3637) * Intergrate consumers in koala theme charts (#3672) * Add consumer to energy flow chart * Add consumer row to daily totals chart * Add consumer total to history chart * add consumer color to store * Align legend category dropdowns * Add consumer component to display flow chart (#3673) * Add consumer component to display flow chart * Add user management role * energy percentage, set usage per json, several fixes (#3705) * energy percentage, set usage per json * consider min interval * fixes * pv * fix * pycheck, fix extra meter * ammend * fixes * ammend * fix * switch interval elapsed * flake8 * improve wait for start * shelly, pytest (#3730) * add shelly, flake8, pytest consumer chargemodes * fix shelly * existing pytests running * review * fix colors, lookup dict names and colors for consumers (#3736) * fix colors, lookup dict names and colors for consumers * review * hide mode controls for consumer measurement only (#3715) * update consumer-configuration-access (user management) (#3743) * diagram colors, pytests, remove extra meters from log data (#3742) * fix colors, lookup dict names and colors for consumers * review * extend tests * add colors for yearly graph data * remove extra meters from log data * remove comment * flake8 * ammend * fix_merge * switch mode on card * update consumer button groups * update message - data order in consumer card * linting * reapply lost changes from #3715 * usage type self controlled (#3775) * usage type self controlled * fix * review * review (#3776) * calc on time (#3777) * calc on time * review * pytest (#3786) * fix pytest * fixes, pytest * review * fix * fixes (#3794) * typo * fix * pytest * Reworked IDM and Lambda consumer and add Ovum (#3737) * IDM: send PV/Hausverbrauch/Batterie via GLT statt Leistungsvorgabe * Lambda: PV-Überschuss statt power_limit an E-Manager senden * Add OVUM CubeSpeicher/MPlus consumer module * IDM: revert scaling factor, fix flake8 formatting * flake8 * Rename send_grid_values to send_values in config.py * Adjust surplus calculation to account for charging power Include charging power in surplus calculation to avoid misreporting surplus to the heat pump. * Update send_values function to send grid power * Add Self_Controlled for IDM and Lambda * flake8: fix syntax error and whitespace in consumer modules Stray pasted line broke lambda_ consumer.py syntax; idm/lambda_/ovum files had trailing whitespace on blank lines and missing EOF newlines. * split PR: remove moduls except mqtt * fix loadmanagement, clean up (#3819) * clean up * fix loadmanagement * review * review * flake8 * fix versions * fix merge error * consider non charging for consumers and update consumer state messages (#3840) * no charge for loads * consider non charging for consumers and update consumer state messages * flake8 * review * fix rebase * pass data object as parameter in set_power_limit methode (#3854) * fix some type hints (#3866) * fix reset of consumer state string (#3887) * pass data object as parameter in set_power_limit methode, review (#3856) * improve * review: update comments * flake8 * fix rebase * Verbraucher: Fixes für Löschen & Hinzufügen (#3909) * fixes delete consumer, add consumer * review * Verbraucher: Fixes für Topics und Anlauferkennung (#3911) * fixes * type hint * fix thread handling (#3912) --------- Co-authored-by: Copilot Autofix powered by AI <[email protected]> Co-authored-by: BrettS <[email protected]> Co-authored-by: Brett-S-OWB <[email protected]> Co-authored-by: Lutz Bender <[email protected]> Co-authored-by: SeaSpotter <[email protected]> Co-authored-by: benderl <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openWB/openwb-ui-settings#1039