Repository navigation
Fix BMW_Cardata - #3778
Merged
Merged
Fix BMW_Cardata#3778
Conversation
Refactor BMW CarData attributes for better compatibility with newer vehicles. Update container creation logic to handle missing descriptors gracefully.
Added tests for SOC extraction and container creation retries.
Updated comments for clarity on attribute priority and backward compatibility.
Updated comments and added new field candidates for battery management attributes.
LKuemmel
approved these changes
Aug 11, 2026
ndrsnhs
pushed a commit
to ndrsnhs/core
that referenced
this pull request
Aug 24, 2026
* Refactor BMW CarData attributes and container creation Refactor BMW CarData attributes for better compatibility with newer vehicles. Update container creation logic to handle missing descriptors gracefully. * Enhance SOC tests with new field handling and retries Added tests for SOC extraction and container creation retries. * Refine comments on attribute handling in soc.py Updated comments for clarity on attribute priority and backward compatibility. * Refine BMW CarData SOC attributes and comments Updated comments and added new field candidates for battery management attributes. * Add tests for SOC and odometer fallback behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixt SoC/Range/Odometer-Extraktion für Fahrzeuge, bei denen die bisherigen BMW-CarData-Attribute nicht mehr existieren (u. a. iX1, MINI, "Neue Klasse") – siehe #3420. Attribute werden jetzt über priorisierte Fallback-Listen ausgelesen, Container-Erstellung versucht Erstellung erneut automatisch ohne veraltete Descriptoren, falls diese für das Fahrzeug nicht verfügbar sind.