Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Solarfocus “Vampair” consumer integration (Modbus TCP-based) and aligns a few existing consumers/sample code with recent API/config changes.
Changes:
- Introduce
packages/modules/consumers/solarfocus/vendor descriptor and a newvampairconsumer + configuration. - Fix my-PV Elwa-E limiting logic (clamp to
>= 0) and correctnonlocalusage. - Update generic JSON consumer config to use
jq_currentstuple and adjust JSON consumer action invocations; update sample consumer import.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/modules/consumers/solarfocus/vendor.py | Adds vendor descriptor for the new Solarfocus consumer family. |
| packages/modules/consumers/solarfocus/vampair/consumer.py | Implements the Vampair consumer using Modbus TCP and sim counting. |
| packages/modules/consumers/solarfocus/vampair/config.py | Adds configuration/setup model for Vampair consumer. |
| packages/modules/consumers/solarfocus/vampair/init.py | Package marker for the new consumer module. |
| packages/modules/consumers/solarfocus/init.py | Package marker for the new vendor namespace. |
| packages/modules/consumers/my_pv/elwa_e/consumer.py | Fixes power-limit clamping and nonlocal bindings. |
| packages/modules/consumers/generic/json/consumer.py | Adjusts JSON consumer action calls to match current helper function patterns. |
| packages/modules/consumers/generic/json/config.py | Consolidates current filters into jq_currents tuple. |
| docs/samples/sample_consumer/sample_consumer/consumer.py | Updates sample consumer import (currently to an invalid module path). |
Suppressed comments (2)
packages/modules/consumers/generic/json/consumer.py:85
- Same issue as
switch_on(): the no-op function returned whenjq_switch_offis unset won’t acceptparams=.... Pass the payload positionally to avoidTypeErrorwhen this feature isn’t configured.
jq_switch_off(params={"state": False})
packages/modules/consumers/generic/json/consumer.py:89
- When
jq_set_power_limitis not configured,create_post_function()returns a no-op lambda that won’t accept the keyword argumentparams=.... Pass the payload dict positionally so the call remains a no-op instead of raisingTypeError.
jq_set_power_limit(params={"power_limit": power_limit})
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
LKuemmel
marked this pull request as ready for review
August 18, 2026 13:06
LKuemmel
added a commit
to LKuemmel/core
that referenced
this pull request
Aug 25, 2026
* Vampair * typo * review * review * review
LKuemmel
added a commit
that referenced
this pull request
Sep 9, 2026
* modules * Vampair (#3815) * Vampair * typo * review * review * review * add dataclass object for set_power_limit, DAC (#3855) * draft dac * add dataclass object for set_power_limit * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <[email protected]> --------- Co-authored-by: Copilot Autofix powered by AI <[email protected]> * Fix consumer modules (#3865) * fix configuration type hints * fix consumer type hints and errors * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <[email protected]> --------- Co-authored-by: Copilot Autofix powered by AI <[email protected]> * rewrite dac consumer module (#3878) * fix avm usage (#3913) --------- Co-authored-by: Copilot Autofix powered by AI <[email protected]> Co-authored-by: benderl <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.