Improve Monthly/Yearly Log by AlexanderHa98 · Pull Request #3829 · openWB/core

AlexanderHa98 · 2026-08-20T09:23:35Z

https://github.com/openWB/internal-projects/issues/273
#1872

Copilot

Pull request overview

This PR refactors the measurement logging pipeline to improve monthly/yearly log generation by deriving aggregates from daily logs and persisting computed daily/monthly “totals” artifacts.

Changes:

Simplifies write_log.save_log() to only write daily logs (removes LogType and monthly-log creation).
Reworks process_log.get_monthly_log() / get_yearly_log() to build aggregates from stored daily/monthly totals, with fallback generation when totals files are missing.
Adds midnight tasks in main.py to persist daily totals (and monthly totals on month rollover).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
packages/main.py	Switches 5-min logging to daily-only and adds midnight persistence of daily/monthly totals.
packages/helpermodules/measurement_logging/write_log.py	Removes `LogType` and makes `save_log()` daily-only.
packages/helpermodules/measurement_logging/process_log.py	Replaces monthly/yearly aggregation logic and adds persistence/loading of daily/monthly source totals.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+            today = timecheck.create_timestamp_YYYYMMDD()
+            previous_day = timecheck.get_relative_date_string(today, day_offset=-1)
+            save_daily_source_totals(previous_day)
+
+            prev_month = timecheck.get_relative_date_string(today, month_offset=-1)[:6]
+            # Neuer Monat hat angefangen, daher Monats Totals speichern
+            if today[6:8] == "01":
+                save_monthly_source_totals(prev_month ,None, saveing=True)       


Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Suppressed comments (9)

packages/helpermodules/measurement_logging/process_log.py:827

This skips totals for modules that disappeared before the final snapshot. The daily/monthly source totals can still contain such a module because it was present earlier in the period, but the last raw entry does not; dropping it here makes get_monthly_log/get_yearly_log omit its accumulated energy even though the persisted totals contain it. Initialize a missing module entry and merge its totals instead of continuing.

            module_data = section_data.get(module)
            if not isinstance(module_data, dict) or not isinstance(module_totals, dict):
                continue

packages/helpermodules/measurement_logging/process_log.py:315

The entries here are copied from raw daily snapshots; _apply_source_totals only adds module-level energy fields. Unlike the previous implementation, this path never runs _analyse_energy_source, so monthly entries have no energy_source and the response has no top-level message, changing the established monthly-log response shape. Run the normal analysis on data after calculating the totals.

        data["totals"] = analyse_percentage_totals(data["entries"], data["totals"])

packages/helpermodules/measurement_logging/process_log.py:332

The comment misspells unnötige as unötige.

    # Sonst werden unötige totals Werte gespeichert

packages/helpermodules/measurement_logging/update_yields.py:125

monthly_totals is a new storage format, so existing installations will have historical monthly_log files but no files in this directory. This loop only sums already-created monthly_totals, causing yearly_exported to reset to the current month's production after upgrade and never recover prior months unless another path happens to rebuild them. Add a migration/fallback for missing months.

            content = load_monthly_source_totals_content(month)
            if content is not None:
                totals = content.get("totals", {})

packages/helpermodules/measurement_logging/process_log.py:379

The yearly path has the same response-shape regression: its entries are assembled without energy_source, and no top-level message is produced because only percentage totals are calculated. Apply _analyse_energy_source to the assembled yearly data before returning it, as the old yearly implementation did.

        data["totals"] = analyse_percentage_totals(data["entries"], data["totals"])

packages/helpermodules/measurement_logging/process_log.py:283

Unlike the yearly loop, this monthly loop has no future-date bound. A request for any month after the current month therefore walks every day, calls save_daily_source_totals with saving=True, and creates a file of empty daily-total records even though no daily log exists. Bound the loop to the current month before attempting the fallback save.

This issue also appears in the following locations of the same file:

line 315
line 825

    while day.startswith(date):

packages/helpermodules/measurement_logging/process_log.py:269

The comment misspells unnötige as unötige.

This issue also appears on line 332 of the same file.

    # Sonst werden unötige totals Werte gespeichert

packages/helpermodules/measurement_logging/update_yields.py:94

On an upgrade, existing daily_log files do not have corresponding daily_totals files. When that happens this branch leaves the day out instead of deriving/migrating its totals, so the published current-month PV yield silently loses all pre-upgrade days (and any day whose midnight save failed). Please calculate and persist missing daily totals rather than treating them as zero.

This issue also appears on line 123 of the same file.

            content = load_daily_source_totals_content(day)
            if content is not None:
                totals = content.get("totals", {})

packages/helpermodules/measurement_logging/update_yields.py:116

The comment misspells Monats as Montas.

    # Wenn es noch keinen Montas Totals gibt

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

packages/main.py:244

In handler_midnight gibt es unnötige Whitespaces und ein unklarer positionaler None-Parameter. Das erschwert das Lesen und sorgt leicht für Verwechslungen, weil save_monthly_source_totals ein benanntes data-Argument hat.

            prev_month = timecheck.get_relative_date_string(today, month_offset=-1)[:6]
            # Neuer Monat hat angefangen, daher Monats Totals speichern
            if today[6:8] == "01":
                save_monthly_source_totals(prev_month ,None, saving=True)

packages/helpermodules/measurement_logging/process_log.py:276

Kleiner Tippfehler im Kommentar: "unötige" sollte "unnötige" heißen (und "Totals-Werte" ist besser lesbar).

    # Nur Logs ab dem ältesten Tageslog auswerten
    # Sonst werden unötige totals Werte gespeichert
    oldest_log_day = _oldest_log_day()

+    monkeypatch.setattr("helpermodules.measurement_logging.process_log._get_data_folder_path",
+                        Mock(return_value="/tmp"))


Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.


-def update_pv_monthly_yearly_yields():
-    """ veröffentlicht die monatlichen und jährlichen Erträge für PV
+def update_pv_monthly_yearly_yields(daily_totals: Dict) -> None:


LKuemmel · 2026-09-11T09:24:49Z

+BASE_PATH = Path(__file__).resolve().parents[3]
+LOG_DIR = BASE_PATH / "ramdisk"
+LOG_FILE = LOG_DIR / "generate_totals.log"
+
+LOG_DIR.mkdir(parents=True, exist_ok=True)
+
+handler = RotatingFileHandler(
+    filename=LOG_FILE,
+    maxBytes=5 * 1024 * 1024,  # 5 MB,
+    backupCount=1,
+)
+
+logging.basicConfig(
+    handlers=[handler],
+    level=logging.DEBUG,
+    format="%(asctime)s [%(levelname)s] %(message)s",
+)
+
+log = logging.getLogger(__name__)


Logfiles bitte in der logger.py anlegen, damit alles zentral gepflegt wird. Die ramdisk hat eine begrenzte Größe und das sollte man dann darüber im Blick behalten können.
Evtl Probleme tauchen im main.log nicht auf. Macht es Sinn, die generate_totals.log auch im UI anzubieten?

LKuemmel · 2026-09-11T09:28:03Z

+                # Behebt Circular-Import-Fehler
+                from helpermodules.measurement_logging.write_log import (
+                    LegacySmartHomeLogData,
+                    create_entry,
+                    get_previous_entry
+                )


Nach dem Python Style Guide sollen die Imports immer am Dateianfang stehen. Wäre gut, wenn das hier auch noch klappt. Da können wir nochmal zusammen nach schauen.

Wenn man die Imports an den Dateianfang schiebt, müssen die Monkeypatches angepasst werden:

--- a/packages/helpermodules/measurement_logging/process_log_unit_test.py +++ b/packages/helpermodules/measurement_logging/process_log_unit_test.py @@ -297,10 +297,10 @@ def test_collect_daily_log_data_current_day(monkeypatch): monkeypatch.setattr('helpermodules.measurement_logging.process_log.json.load', mock_json_load) mock_create_entry = Mock(return_value=mock_current_entry) - monkeypatch.setattr('helpermodules.measurement_logging.write_log.create_entry', mock_create_entry) + monkeypatch.setattr('helpermodules.measurement_logging.process_log.create_entry', mock_create_entry) mock_get_previous_entry = Mock(return_value={"timestamp": 1234567800, "data": "previous"}) - monkeypatch.setattr('helpermodules.measurement_logging.write_log.get_previous_entry', mock_get_previous_entry) + monkeypatch.setattr('helpermodules.measurement_logging.process_log.get_previous_entry', mock_get_previous_entry) monkeypatch.setattr('builtins.open', mock_open(read_data=json.dumps(mock_log_data)))

Copilot

Note

Copilot was unable to run its full agentic suite in this review.

Copilot review overview

Review effort: Lite
Findings: 6 · 10 · 4

Open (20)

file_operation_version is only normalized for None and int, but can still be an unexpected… · New
decode_payload(...) can return None or a non-list type; this code assumes it is a mutable list… · New
At midnight, save_daily_source_totals(previous_day) relies on… · New
Die Initialisierung von file_operation_version setzt bei fehlendem Topic aktuell eine Liste, die…
save_log catches its own failures and returns None, and update_daily_yields also returns…
handler_midnight() no longer creates/updates data/monthly_log/<YYYYMM>.json, but…
Totals generation has been refactored so a lot of log output now likely comes from… · New
Previously get_monthly_log() returned the result of _analyse_energy_source(...), which… · New
update_pv_monthly_yearly_yields(...) is triggered in the 5‑minute handler, and… · New
The subprocess uses a hard-coded cwd (/var/www/html/openWB/packages). If the installation path… · New
Der Zugriff auf data.data.system_data["system"].data["log_totals_generation_finished"] kann einen…
upgrade_file_operation_0() trägt Version 0 auch dann als erledigt ein, wenn der Subprocess nicht…
Der Test nutzt einen festen Pfad "/tmp" für _get_data_folder_path. Falls dort bereits…
print(...) in einer Library-Funktion schreibt direkt auf stdout und umgeht das zentrale Logging…
In save_daily_source_totals(), _process_entries() mutates the list in-place (including popping…
_oldest_log_day() uses st_ctime as “creation time”, but on Linux ctime is inode change time…
Lock contention (already-running subprocess) is an expected condition, but log.exception(...)… · New
Für die neu eingeführte Logik zur Berechnung/Publikation der PV-Monats- und Jahreserträge…
save_monthly_source_totals() is annotated with data: Dict, but the function explicitly accepts…
The keyword/parameter name saveing is misspelled (should be saving). Because this is now part…

+    def __solve_breaking_changes_filesystem(self) -> None:
+        """Führt dateisystembezogene Migrationen anhand der file_operation_version aus."""
+        file_operation_version = decode_payload(self.all_received_topics.get("openWB/system/file_operation_version"))
+        if file_operation_version is None:
+            # Neues Topic (z.B. bei Upgrade von älteren Versionen): alle File-Operation-Upgrades ausführen.
+            file_operation_version = []
+            self.__update_topic("openWB/system/file_operation_version", file_operation_version)
+        elif isinstance(file_operation_version, int):
+            # Legacy-Format (int): bereits ausgeführte Upgrades als Liste abbilden.
+            file_operation_version = list(range(file_operation_version))
+            self.__update_topic("openWB/system/file_operation_version", file_operation_version)
+
+        log.debug(f"current file operation version: {file_operation_version}")
+        log.debug(f"target file operation version: {self.FILE_OPERATION_VERSION}")
+        for version in list(range(self.FILE_OPERATION_VERSION+1)):
+            try:
+                operation_required = version not in file_operation_version
+                if version == 0:
+                    # Version 0 erneut ausführen, solange die Hintergrund-Generierung der Tages-/Monatssummen
+                    # noch nicht erfolgreich abgeschlossen ist (Flag ist nicht True).
+                    log_totals_generation_finished = decode_payload(
+                        self.all_received_topics.get("openWB/system/log_data_ready"))
+                    operation_required = operation_required or log_totals_generation_finished is not True


+    def _append_file_operation_version(self, version: int) -> None:
+        file_operation_versions = decode_payload(self.all_received_topics.get("openWB/system/file_operation_version"))
+        if version not in file_operation_versions:
+            file_operation_versions.append(version)
+            self.__update_topic("openWB/system/file_operation_version", file_operation_versions)


+            today = timecheck.create_timestamp_YYYYMMDD()
+            previous_day = timecheck.get_relative_date_string(today, day_offset=-1)
+            save_daily_source_totals(previous_day)
+
+            prev_month = timecheck.get_relative_date_string(today, month_offset=-1)[:6]
+            # Neuer Monat hat angefangen, daher Monats Totals speichern
+            if today[6:8] == "01":
+                save_monthly_source_totals(prev_month, None, saving=True)       


+        process_log = logging.getLogger("helpermodules.measurement_logging.process_log")
+        process_log.setLevel(logging.DEBUG)
+        process_log.propagate = False
+        if handler not in process_log.handlers:
+            process_log.addHandler(handler)


+    if not (len(date) == 6 and date.isdigit()):
+        log.debug(f"Ungültiges Datum für Monats-Summen: {date}")
+        return {"entries": [], "names": {}, "colors": {}, "totals": {}}


+    daily_log_path = _get_parent_path()/"data"/"daily_log"
+
+    for logfile in sorted(daily_log_path.glob(f"{this_month}*.json")):
+        day = logfile.stem
+        totals = {}
+        if day == today:
+            continue  # Der aktuelle Tag wird später behandelt
+        else:
+            # Lade alle vergangenen Tage des Monats aus dem daily_totals-Logfile, um die Tageserträge zu ermitteln
+            content = load_daily_source_totals_content(day)
+            if content is None:
+                # Fallback/Migration: fehlende Tages-Totals aus den Tageslogs berechnen und speichern.
+                content = save_daily_source_totals(day, saving=True)
+            if isinstance(content, dict):
+                totals = content.get("totals", {})


+        self.__update_topic("openWB/system/log_data_ready", False)
+        try:
+            _generate_totals_subprocess = subprocess.Popen(
+                [
+                    sys.executable,
+                    "-m",
+                    "helpermodules.measurement_logging.generate_totals_subprocess"
+                ],
+                cwd="/var/www/html/openWB/packages",
+                start_new_session=True,
+                stdin=subprocess.DEVNULL,
+                stdout=subprocess.DEVNULL,
+                stderr=subprocess.DEVNULL,
+                close_fds=True
+            )


+        except Exception:
+            log.exception("generate_totals_subprocess läuft bereits. "
+                          "Der zweite Prozess wird beendet.")
+            return


Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot review overview

🟡 Changes recommended

Critical and moderate correctness and migration-readiness issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 6 · 5 · 2

Open (13)

Wait for readiness publish before subprocess exit · New
Recompute aggregate energy source mix · New
At midnight, save_daily_source_totals(previous_day) relies on…
decode_payload(...) can return None or a non-list type; this code assumes it is a mutable list…
file_operation_version is only normalized for None and int, but can still be an unexpected…
handler_midnight() no longer creates/updates data/monthly_log/<YYYYMM>.json, but…
The subprocess uses a hard-coded cwd (/var/www/html/openWB/packages). If the installation path…
update_pv_monthly_yearly_yields(...) is triggered in the 5‑minute handler, and…
Previously get_monthly_log() returned the result of _analyse_energy_source(...), which…
Totals generation has been refactored so a lot of log output now likely comes from…
Der Test nutzt einen festen Pfad "/tmp" für _get_data_folder_path. Falls dort bereits…
Lock contention (already-running subprocess) is an expected condition, but log.exception(...)…
Für die neu eingeführte Logik zur Berechnung/Publikation der PV-Monats- und Jahreserträge…

Resolved since last review (9)

Die Initialisierung von file_operation_version setzt bei fehlendem Topic aktuell eine Liste, die…
save_log catches its own failures and returns None, and update_daily_yields also returns…
Der Zugriff auf data.data.system_data["system"].data["log_totals_generation_finished"] kann einen…
upgrade_file_operation_0() trägt Version 0 auch dann als erledigt ein, wenn der Subprocess nicht…
print(...) in einer Library-Funktion schreibt direkt auf stdout und umgeht das zentrale Logging…
In save_daily_source_totals(), _process_entries() mutates the list in-place (including popping…
_oldest_log_day() uses st_ctime as “creation time”, but on Linux ctime is inode change time…
save_monthly_source_totals() is annotated with data: Dict, but the function explicitly accepts…
The keyword/parameter name saveing is misspelled (should be saving). Because this is now part…

Previously missed (1)

In code that hasn't changed since last review

Publish readiness only when all conversions succeed

packages/helpermodules/measurement_logging/generate_totals_subprocess.py:72

The subprocess publishes log_data_ready=True even when one or more conversions failed and were counted in errors. That marks incomplete totals as ready and prevents the next configuration update from retrying the failed work, so monthly/yearly values can remain incomplete. Only publish the ready flag when the generation completed without errors.

+            continue
+
+    log.info(f"Totals-Migration abgeschlossen. Fehlerhafte Logs: {errors}.")
+    pub.Pub().pub("openWB/set/system/log_data_ready", True)


+        daily_entry = {}
+        if source_daily_entry is not None:
+            daily_entry = deepcopy(source_daily_entry)
+            daily_entry["date"] = date
+            _apply_source_totals(daily_entry, totals)


* Improve Log * Move generate_totals-Logger in logger.py * Fix * Fix Circular Import * Update .gitignore * fix * Ensure ramdisk folder exists * retrigger Copilot * Add Copilot suggestions * fix

* dimm kit: improve error handling, handle deleted output devices (#3868) * dimm kit: improve error handling, handle deleted output devices * review, complete logging * Apply batched suggestions from code review Co-authored-by: Copilot Autofix powered by AI <[email protected]> * fixes * add pytest --------- Co-authored-by: Copilot Autofix powered by AI <[email protected]> * PV-Reset: NO_CHARGING_ALLOWED blockiert den robustness-Reset nicht mehr (#3968) Nach PR #3966 blockierte ein eingesteckter, aber unterhalb der Einschaltschwelle wartender Ladepunkt (Zustand NO_CHARGING_ALLOWED) weiterhin dauerhaft den Reset von reserved_surplus/released_surplus - das ist aber der mit Abstand häufigste, langlebigste Zustand eines PV-ladenden Fahrzeugs. Jede Reservierung wird jedoch bereits beim Übergang in diesen Zustand freigegeben (siehe zB Counter.reset_switch_on_off()), sodass er nie mit einer noch offenen Reservierung erreicht wird - er gehörte also nie in die Blockierliste. Betroffen war zB ein Fall, in dem eine verwaiste reserved_surplus-Reservierung aus einem unterbrochenen Vorgang nie mehr zurückgesetzt wurde, wodurch die Einschaltschwelle dauerhaft nicht mehr erreicht werden konnte (PV-Laden startet gar nicht mehr) - siehe Diskussion. Ersetzt die 5 Einzelvergleiche + Chargepoint/Consumer-Fallunterscheidung + plug_state-Sonderfall durch eine einzige Zustandsliste der tatsächlich reservierungshaltenden Zustände (PERFORMING_PHASE_SWITCH, PHASE_SWITCH_DELAY, SWITCH_OFF_DELAY, SWITCH_ON_DELAY), verifiziert gegen jede +=/-=-Stelle in counter.py/ev.py/chargepoint.py. references #3908 (reply in thread) * fix: external_openwb chargepoint crashes when fault_state topic is missing (#3970) get_values() indexed received_topics[fault_state] directly, including inside its own KeyError handler - if the paired internal chargepoint hadn't published fault_state yet (startup, reconnect), the fallback crashed on the exact same missing key instead of handling it. * consumer: fix hierarchy, default usage (#3975) * consumer: fix hierarchy, default usage * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <[email protected]> --------- Co-authored-by: Copilot Autofix powered by AI <[email protected]> * fix: external_openwb occasionally missed retained MQTT topics under load (#3976) start_finite_loop()'s fixed 1s collection window left little margin for connection/handshake overhead when the paired internal chargepoint was busy (eg mid-charge), occasionally causing get_values() to miss a retained topic despite retain=True. Made the timeout configurable (default unchanged for the other 17 call sites) and doubled it for external_openwb specifically, which has to reliably collect ~20 topics over a real network hop rather than one or two local values. * Systembericht Verbraucher (#3956) * add consumers; reorganize structure * improve * fix: Ladepunkte nutzen die Abschaltschwelle der Verbraucher (#3984) calc_switch_off_threshold() liest fuer alle Lasten surplus.consumer.switch_off_threshold. surplus.vehicle.switch_off_threshold ist konfigurierbar, wird migriert und in der Debug-Ausgabe angezeigt, aber im Regelalgorithmus nirgends gelesen. Die Migration verschiebt den alten pv_charging/switch_off_threshold nach surplus/vehicle/switch_off_threshold. Damit regeln bestehende Anlagen seit dem Update mit dem neu angelegten Consumer-Default 0 statt mit dem konfigurierten Wert. * removing meter-only consumers from load management priority (#3998) * removing meter-only consumers from load management priority * review * extend for self_controlled * Potential fix for pull request finding 'Preserve pre-existing empty groups during migration' Co-authored-by: Copilot Autofix powered by AI <[email protected]> --------- Co-authored-by: Copilot Autofix powered by AI <[email protected]> * build UI (#3999) * Update: Hausverbrauch Zähler (#3991) * EVU auf Auto entspricht Ja * fix * avm: fix consumer switch_on/off using unresolved ain, fix bare return in session lookup (#3987) * build UI (#4000) * Feature negative dc charging (#3795) * Add Bidi to instant-charging * Update Koala-UI min/max DC-Sollleistung * fix * Build Themes * avm consumer: invertierte Session-Refresh-Bedingung beheben (#4001) ensure_valid_session_id() erneuerte die Session nur, wenn check_valid_session_id() False war - die Funktion liefert aber "ist ungültig" zurück, nicht "ist gültig". Dadurch wurde nie erneuert, sobald session_id einmal None oder abgelaufen war: alle Anfragen liefen dauerhaft mit sid=None und schlugen mit HTTP 403 fehl. Umbenannt zu session_id_expired(), passend zum tatsächlichen Rückgabewert. * Peak Filter: bei Rückwärtssprüngen auf Wert größer/gleich Höchststand warten (#4007) * Peak Filter: bei Rückwärtssprüngen auf Wert größer/gleich Höchststand warten * review * build UI (#4008) * Consumer: Add Daikin, EGO and EMS-ESP (#3969) * Add Daikin, EGO and EMS-ESP consumer modules * daikin: Air2Air-Fixes aus Review (Lena, PR #3969) + neues Altherma-Modul Air2Air: Name korrigiert ("Daikin Air2Air (HomeHub EKRHH)"), METER_ONLY entfernt (keine Leistungsmessung verfügbar). Neu: daikin_homehub_altherma - eigenes Modul für Daikin Altherma, da eigene Modbus-Register (EKRHH Installer Reference Guide 4PDE744838, Kap. 9, separat von Air2Air/Kap. 10). Register gegen das offizielle Handbuch geprüft: - switch_on/off: Reg 56 (Smart-Grid-Modus), analog zu Air2Airs Reg 1000 - set_power_limit: Reg 58 (Allgemeine Leistungsbegrenzung, gilt laut Handbuch unabhängig vom Smart-Grid-Modus, anders als Reg 57) - update: Input-Reg 51 (Stromverbrauch Wärmepumpe) - Altherma kann im Gegensatz zu Air2Air tatsächlich Leistung melden, daher METER_ONLY hier sinnvoll * Consumer: Add Mitsubishi and Gree AC modules (#3973) * Add Mitsubishi and Gree AC consumer modules * Mitsubishi/Gree: METER_ONLY entfernt, da keine Leistungsmessung Beide Module haben keine update()-Funktion und liefern somit keine Leistungsmessung; ConsumerUsage.METER_ONLY war daher nicht zutreffend. * Gree: tcid im Bind-Request ergänzt (Review Lena) cid muss beim Binden konstant "app" sein, tcid identifiziert das Zielgerät per MAC - bestätigt gegen tomikaa87/gree-remote und cmroche/greeclimate. * build UI (#4010) * Fixed Hours Tariff: migrate fixed-hours weekdays to Python weekday format (#4009) * Hierarchie: Entferne mit Verbraucher verknüpften Zähler (#4011) * Hierarchie: Entferne mit Verbraucher verknüpften Zähler * flake8 * Speicher-Vorrang bei Erholung von Mindest- bis Maximal-SoC (#3986) * bat_all: restore Speicher-Vorrang beim Erholen von Mindest-SoC bis Maximal-SoC * bat_all: Speicherleistung nicht ans Fahrzeug weitergeben, wenn Entladung nicht erlaubt ist * build UI (#4025) * Add ACLs consumer and load management topics (#3964) * Add acls * Add load management prio to status * fix colors theme: leftover pv_charging topic paths from PR #3812 topic migration (#3946) * Build Themes * Consumer: Add Kermi, LG Therma V, Luxtronik (#3971) * Add Kermi, LG Therma V and Luxtronik consumer modules * kermi, luxtronik: Skalierungsfaktoren korrigiert (Review #3971) Kermi Reg 301 (PV-Überschuss): war /10, muss *10 sein. Luxtronik Reg 10301 (el. Leistung): war *10, muss *100 sein. Reg 108 (Kermi) war bereits korrekt. * Sonnenbatterie: add OperationMode Optimization (#3769) * add Mode Optimization * check for valid OperatingMode * Fix load management single phase netting and Bidi discharge currents (#4012) * Lastmanagement: eigenen Ladestrom bei ein-/zweiphasigem Laden nicht mehr als Fremdlast zählen _set_current_left() entschied per min(element_current) < 0, ob der Strom eines Ladepunkts als Verbrauch oder Einspeisung zählt. Bei ein-/zweiphasigem Laden reicht dafür schon minimales negatives Messrauschen auf einer ungenutzten Phase - der eigene Ladestrom wurde dann nirgends vom Zähler-Rohwert abgezogen, das Lastmanagement hielt die eigene Ladung für Fremdlast (falsche "Maximalstromstärke erreicht"/Schieflast-Meldungen, siehe Discussion #3908). _set_power_left() hat exakt dasselbe Problem nicht, da dort schon die Gesamtleistung statt einzelner Phasenströme geprüft wird - jetzt angeglichen. * Bidi-Entladung: eigene Hardware-Stromgrenze des Ladepunkts durchsetzen check_min_max_current() rief check_cp_max_current() (setzt dc_max_current des Ladepunkt-Templates durch) nur im Lade-Zweig auf, nicht beim Entladen (BIDI_CHARGING, required_current < 0) - die vom Fahrzeug gemeldete max_discharge_power wurde beachtet, die eigene Hardwaregrenze des Ladepunkts nicht. Bug in #3795, check_cp_max_current() behandelt negative Werte bereits korrekt (Vorzeichen wird erhalten). * build UI (#4026) * Improve Monthly/Yearly Log (#3829) * Improve Log * Move generate_totals-Logger in logger.py * Fix * Fix Circular Import * Update .gitignore * fix * Ensure ramdisk folder exists * retrigger Copilot * Add Copilot suggestions * fix * Fix Tesla/Powerwall data handling and improve robustness of control loop (#3232) * tesla/powerwall: implement load management, add fail-fast handling and gateway diagnostics - add structured HTTP error handling in PowerwallHttpClient - distinguish transport, HTTP and JSON parsing failures - support fail_fast=False for non-critical requests - track cycle_failed and cookie_renewed state across one polling cycle - add fail-fast handling in device.py - stop remaining Tesla component updates once a critical Powerwall request fails - log native TCP connection state diagnostics via /proc/net/tcp(/tcp6) - emit periodic session / connection health logs - keep cookie reuse, but mark startup + reauth cycles explicitly - reduce /api/status traffic in counter.py - fetch firmware only after startup or after a new auth cookie was negotiated - treat /api/status as non-critical so it cannot fail the whole cycle - keep import/export counters based on aggregate["site"]["energy_imported/exported"] - do not use summed per-phase energy counters as meter source - keep /api/meters/site for phase details only - add derived fallback currents and signed power factors from P/Q/U when Tesla/Neurio currents are 0 - expose additional diagnostics such as frequency / serial number - add throttled debug logging to compare aggregate counters with per-phase sums - restore aggregate-based site counters so load management works correctly again * tesla/powerwall: simplify device/http client and keep cookie reauth handling - remove session / connection diagnostics and analysis-only helpers - remove /proc-based connection stats and periodic session logging - keep fail-fast handling for the Tesla update cycle - keep cookie reuse and 401/403 reauthentication flow - keep support for non-critical requests via fail_fast=False - reduce implementation closer to upstream while preserving Powerwall-specific fixes * tesla/powerwall: simplify device/http client and keep local current fallback - remove analysis-only diagnostics and session tracking from device.py - remove connection stats and other debug-only helpers - simplify http_client.py to a minimal request wrapper - keep cookie reuse and 401/403 reauthentication flow in device.py - use fail-fast handling in device.py via SingleComponentUpdateContext(..., reraise=True) - move Tesla-specific robustness back into the counter module only - keep aggregate["site"]["energy_imported/exported"] as sole source for EVU counters - keep local current and power factor calculation when Neurio/Tesla returns only 0 currents - remove /api/status handling from counter.py - fix formatting / lint issues (newline at EOF, spaces instead of tabs) * Fix Tesla error handling and compatibility note - use central openWB component error handling - remove Tesla-specific fail-fast handling - rely on the shared HTTP response hook - remove obsolete local API compatibility warning * se standard error handling in Tesla counter - remove _safe_float and module-specific defaults - propagate HTTP errors to central error handling - keep compatibility fallback for missing phase data - calculate phase currents from P/Q/U when Tesla reports zero currents * Fix Tesla module lint errors * Adjust Tesla API compatibility note * Error status table (#3943) * add error and warning icons to chargepoint table * Align warning icons - remove extra warning column * No tooltip for mobile - ellipsis title only if truncated * Build Themes * add consumer temperature readings to consumer card (#3974) * add consumer temperature readings to consumer card * check if temperature data is present * use getValueObject for formatting * Build Themes * Consumer: Add M-TEC, Weishaupt, Xtherma (#3972) * Add M-TEC, Weishaupt and Xtherma consumer modules * M-TEC: Reg 707 durch evcc-Quelle bestätigt, Kommentar aktualisiert Reg 707 (elektrische Leistungsaufnahme) ist in evcc's mtec.yaml als holding register mit scale 1 gelistet, identisch zu unserer Implementierung. * Weishaupt: Reg 33126 entfernt (nicht verifizierbar), Xtherma: SG-Ready on/off ergänzt Weishaupt: Reg 33126 (el. Leistungsaufnahme) ist weder in der offiziellen Datenpunktliste (83807301) noch in einer ausgereiften Community-Implementierung (OStrama/weishaupt_modbus) zu finden - update()/METER_ONLY entfernt, SollwertPV (Reg 40002, offiziell dokumentiert) bleibt unverändert. Xtherma: Reg 60 (SG-Ready-Modus) ergänzt switch_on/switch_off (SUSPENDABLE_ONOFF), eigener 30min-Throttle laut Protokoll. * Fix charge cost calc (#4022) * fix chargelog energy source calculation * Add Test * fix circular error --------- Co-authored-by: LKuemmel <[email protected]> Co-authored-by: Copilot Autofix powered by AI <[email protected]> Co-authored-by: SeaSpotter <[email protected]> Co-authored-by: ndrsnhs <[email protected]> Co-authored-by: s0170071 <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: BrettS <[email protected]> Co-authored-by: NicoP-codeing <[email protected]>

* Improve Log * Move generate_totals-Logger in logger.py * Fix * Fix Circular Import * Update .gitignore * fix * Ensure ramdisk folder exists * retrigger Copilot * Add Copilot suggestions * fix

* Keep small charged energy amounts (#3905) * Fix charge cost calc (#4022) * fix chargelog energy source calculation * Add Test * Improve Monthly/Yearly Log (#3829) * Improve Log * Move generate_totals-Logger in logger.py * Fix * Fix Circular Import * Update .gitignore * fix * Ensure ramdisk folder exists * retrigger Copilot * Add Copilot suggestions * fix * Fix charge cost calc (#4022) * fix chargelog energy source calculation * Add Test * fix circular error * Remove duplicate function * Revert previous change * Add copilot suggestion

AlexanderHa98 requested a lite review from Copilot August 20, 2026 09:29

AlexanderHa98 self-assigned this Aug 20, 2026

Copilot started reviewing on behalf of AlexanderHa98 August 20, 2026 09:30

View session

Copilot AI reviewed Aug 20, 2026

View reviewed changes

AlexanderHa98 requested a lite review from Copilot August 21, 2026 06:06

Copilot started reviewing on behalf of AlexanderHa98 August 21, 2026 06:07

View session

Copilot AI reviewed Aug 21, 2026

View reviewed changes

Comment thread packages/main.py Resolved

AlexanderHa98 requested a lite review from Copilot August 26, 2026 06:33

Copilot started reviewing on behalf of AlexanderHa98 August 26, 2026 06:33

View session

Copilot AI reviewed Aug 26, 2026

View reviewed changes

AlexanderHa98 requested a lite review from Copilot August 28, 2026 08:22

Copilot started reviewing on behalf of AlexanderHa98 August 28, 2026 08:23

View session

Copilot AI reviewed Aug 28, 2026

View reviewed changes

AlexanderHa98 marked this pull request as ready for review September 2, 2026 05:39

AlexanderHa98 requested a review from LKuemmel September 2, 2026 05:39

benderl added the ui depends on changes in ui repository label Sep 3, 2026

benderl mentioned this pull request Sep 3, 2026

Improve Monthly/Yearly Log openWB/openwb-ui-settings#1068

Merged

LKuemmel requested changes Sep 11, 2026

View reviewed changes

AlexanderHa98 force-pushed the feature_improve_monthly_log branch from e6546fc to 7b1e794 Compare September 23, 2026 13:35

AlexanderHa98 requested a lite review from Copilot September 23, 2026 13:52

Copilot started reviewing on behalf of AlexanderHa98 September 23, 2026 13:53

View session

Copilot stopped reviewing on behalf of AlexanderHa98 due to an error September 23, 2026 13:53
An unexpected error occurred. For more details, see the detailed logs in GitHub Actions.

Copilot AI reviewed Sep 23, 2026

View reviewed changes

AlexanderHa98 requested a lite review from Copilot September 23, 2026 14:08

Copilot AI reviewed Sep 23, 2026

AlexanderHa98 requested a lite review from Copilot September 23, 2026 14:12

Copilot started reviewing on behalf of AlexanderHa98 September 23, 2026 14:12

View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

AlexanderHa98 requested a review from LKuemmel September 24, 2026 06:12

LKuemmel approved these changes Sep 24, 2026

View reviewed changes

AlexanderHa98 added 10 commits September 28, 2026 14:22

Improve Log

8d97f8c

Move generate_totals-Logger in logger.py

6e76e6f

Fix

50bb1ca

Fix Circular Import

8b2d651

Update .gitignore

ca79e8b

fix

76142ee

Ensure ramdisk folder exists

0552a87

retrigger Copilot

07fc783

Add Copilot suggestions

85ae6ed

fix

59b1ccb

LKuemmel force-pushed the feature_improve_monthly_log branch from de9e279 to 59b1ccb Compare September 28, 2026 12:22

LKuemmel merged commit 417fb0c into openWB:master Sep 28, 2026
1 check passed

LKuemmel linked an issue Oct 19, 2026 that may be closed by this pull request

Diskrepanz zwischen Tages-Log und Monats-Log bei PV-Anteilen #1872

Closed

		monkeypatch.setattr("helpermodules.measurement_logging.process_log._get_data_folder_path",
		Mock(return_value="/tmp"))

Conversation

AlexanderHa98 commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LKuemmel Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LKuemmel Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

LKuemmel Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AlexanderHa98 commented Aug 20, 2026 •

edited

Loading