Repository navigation
Fix Anker Solarbank - #3832
Merged
Merged
Fix Anker Solarbank#3832
Conversation
Removed POWER_GAIN constant and adjusted power calculations accordingly.
Corrected register addresses for reading currents.
Fix formatting issue by adding a newline at the end of the file.
Removed commented code regarding power value calculation and adjusted the power limit logic.
Removed AnkerCounterConfiguration and AnkerCounterSetup classes.
Updated power calculation to use dc_power from register 10002 instead of Load_power from register 10010. Added logging for ac_grid_output_power from register 10208 for debugging purposes.
Added logging to debug current and power values before processing.
Removed dc_power from InverterState initialization.
ndrsnhs
approved these changes
Aug 20, 2026
ndrsnhs
pushed a commit
to ndrsnhs/core
that referenced
this pull request
Aug 24, 2026
* Change word order to Big Endian in counter.py * Refactor power calculations in inverter.py Removed POWER_GAIN constant and adjusted power calculations accordingly. * Refactor power calculations and remove POWER_GAIN * Change word order to Big Endian in counter.py * Change word order to Big Endian for power readings * Change word order in power reading to Big Endian * Fix register address for currents in update method Corrected register addresses for reading currents. * Add newline at end of counter.py Fix formatting issue by adding a newline at the end of the file. * Refactor power value calculation and logging * Refactor power limit handling in bat.py Removed commented code regarding power value calculation and adjusted the power limit logic. * Delete packages/modules/devices/anker/solarbank_max_ac/counter.py * Remove AnkerCounterConfiguration and Setup classes Removed AnkerCounterConfiguration and AnkerCounterSetup classes. * Remove counter component from device.py * Refactor power calculation and add logging Updated power calculation to use dc_power from register 10002 instead of Load_power from register 10010. Added logging for ac_grid_output_power from register 10208 for debugging purposes. * Add logging for current and power debugging Added logging to debug current and power values before processing. * Delete packages/modules/devices/anker/solarbank_max_ac/__init__.py * Delete packages/modules/devices/anker/solarbank_max_ac/bat.py * Delete packages/modules/devices/anker/solarbank_max_ac/config.py * Delete packages/modules/devices/anker/solarbank_max_ac/device.py * Delete packages/modules/devices/anker/solarbank_max_ac/inverter.py * Update Anker class name and type attributes * Refactor import paths for Anker device module * Move bat.py to new solarbank directory * Move inverter.py to new solarbank directory * Delete packages/modules/devices/anker/solarbank_4_e5000/__init__.py * Add files via upload * Remove debug logging from counter.py * Update update_config.py * Remove dc_power from inverter state Removed dc_power from InverterState initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI: openWB/openwb-ui-settings#1056
Leider nochmal ein PR dazu, entgegen meiner ersten Annahme sind die Solarbank Moduelle in den Registern doch nicht mehr unterschiedlich und die Solarbank Max AC unterstützt das Auslesen des Zählers über die Solarbank nicht mehr.
#3446 (reply in thread)
Ich habs jetzt mit Hilfe von @Tuffiglig live an einer Solarbank 4 testen und verifizieren können.