Repository navigation
dimm kit: modbus client context manager, type hints - #3848
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dimm kit IO module to use the Modbus TCP client as a context manager, ensuring Modbus connections are opened/closed in a controlled scope during reads/writes.
Changes:
- Wrap Modbus read operations in
with client:to leverage__enter__/__exit__lifecycle handling. - Wrap Modbus write operations (including initializer output setup) in
with client:for consistent connection handling. - Add small inter-call delays (
time.sleep(0.1)) around IO operations (notably during initializer output writes).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
benderl
reviewed
Aug 25, 2026
benderl
reviewed
Aug 25, 2026
benderl
reviewed
Aug 25, 2026
Comment on lines
+75
to
+80
| with client: | ||
| for output, value in config.output["digital"].items(): | ||
| time.sleep(0.1) | ||
| client.write_single_coil(DigitalOutputMapping[output].value, | ||
| value, | ||
| unit=config.configuration.modbus_id) |
Contributor
There was a problem hiding this comment.
Wäre es nicht sinnvoller, hier auch write() aufzurufen? Der Code ist identisch, abgesehen davon, dass hier noch ein sleep zwischen den Aufrufen gibt, was aber anscheinend nicht notwendig ist, siehe write().
benderl
requested changes
Aug 25, 2026
LKuemmel
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Suppressed comments (1)
packages/modules/io_devices/dimm_kit/api.py:78
- The configured digital-output mapping is not validated as non-empty, contiguous, or enum-ordered. This now raises
IndexErrorfor an empty mapping and can write values to the wrong coils for sparse/out-of-order persisted configurations; the previous per-key loop handled all of these valid dictionary shapes.
client.write_coils(DigitalOutputMapping[list(config.output["digital"].keys())[0]].value,
list(config.output["digital"].values()),
unit=config.configuration.modbus_id)
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
…nto feature_dimm_kit
Brett-S-OWB
pushed a commit
that referenced
this pull request
Sep 2, 2026
* dimm kit: modbus client dimm kit * review * type hints * review * fix * don't reinit io device if io action is reconfigured * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <[email protected]> * review --------- Co-authored-by: Copilot Autofix powered by AI <[email protected]>
benderl
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket #66006528
ersetzt https://github.com/openWB/core/tree/feature_dimm_kit_base_release für den PR