Skip to content

Colors theme: updates and fixes - #3933

Closed
cshagen wants to merge 3 commits into
openWB:masterfrom
cshagen:update-web-2609
Closed

cshagen wants to merge 3 commits into
openWB:masterfrom
cshagen:update-web-2609

Conversation

@cshagen

@cshagen cshagen commented Sep 13, 2026 •

Copy link
Copy Markdown
Collaborator
  • Dependencies aktualisiert
  • Korrektur des Mouseovers im Pricechart (aufgrund Meldung im Forum)
  • Korrektur der Preiskurve im Power-Graphen (aufgrund Feedback im Forum)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved lint and price-curve issues, plus removal of PV feed-in-limit support, block approval.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates the Colors web theme’s tooling, dependencies, tooltip behavior, and graph rendering.

Changes:

  • Updates Vite configuration and frontend dependencies.
  • Adjusts chart tooltips, price processing, stepped curves, and tooltip sizing.
  • Removes the PV feed-in-limit model/control and shortens the README.
File summaries
File Description
packages/modules/web_themes/colors/source/vite.config.ts Updates Vite polyfill configuration.
packages/modules/web_themes/colors/source/tsconfig.app.json Simplifies path configuration.
packages/modules/web_themes/colors/source/src/components/priceChart/PriceChart.vue Scopes tooltip groups per chart.
packages/modules/web_themes/colors/source/src/components/powerGraph/processDayGraphData.ts Adjusts price data processing.
packages/modules/web_themes/colors/source/src/components/powerGraph/PriceLine.vue Adds stepped price rendering.
packages/modules/web_themes/colors/source/src/components/powerGraph/PgToolTipItem.vue Adjusts tooltip height calculation.
packages/modules/web_themes/colors/source/src/components/chargePointList/model.ts Removes feed-in-limit model support.
packages/modules/web_themes/colors/source/src/components/chargePointList/cpConfig/ConfigPv.vue Removes the feed-in-limit control.
packages/modules/web_themes/colors/source/README.md Replaces setup documentation with a brief description.
packages/modules/web_themes/colors/source/package.json Updates dependencies and tooling.
Review details

Suppressed comments (3)

packages/modules/web_themes/colors/source/src/components/chargePointList/model.ts:74

  • Removing this property and its matching control in ConfigPv.vue drops the Einspeisegrenze beachten setting from this theme, even though the backend still exposes and applies feed_in_limit and the parallel colors display theme still provides it. Existing users will no longer be able to change this setting from the web theme; please retain the model/UI support or explicitly migrate the feature.
	private _pvMinCurrent = 0

packages/modules/web_themes/colors/source/src/components/powerGraph/PriceLine.vue:79

  • curveStepBefore moves each tariff change to just before the point's timestamp. The backend treats each tariff key as effective at that timestamp (packages/modules/common/store/_tariff.py:61-68), so this path should use the already imported curveStepAfter to avoid displaying every price interval one sample early.
		.curve(curveStepBefore)

packages/modules/web_themes/colors/source/src/components/powerGraph/PriceLine.vue:104

  • The autozoom redraw uses the same curveStepBefore direction, so even if the initial path is corrected, zooming still shifts the price curve one interval early. Use curveStepAfter here as well to keep both rendered paths consistent with the timestamp semantics.
			.curve(curveStepBefore)
  • Files reviewed: 10/11 changed files
  • Comments generated: 3
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@cshagen

cshagen commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator Author

2 Copilot findings gefixt. Der Dritte bezog sich auf eine Änderung in einem früheren MR.

@benderl

benderl commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@cshagen
Ich habe den PR übersehen, als ich gestern die anderen beiden gemerged habe. Gibt es noch offene Punkte aus diesem PR oder sind die Anpassungen jetzt bereits im master?

@cshagen

cshagen commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

Es sieht so aus, als wäre das alles schon im master. Ich schliesse den PR.

@cshagen cshagen closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants