Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/modules/vehicles/tronity/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def write_token_mqtt(topic: str, token: str, config: TronityVehicleSocConfigurat


def create_session(config: TronityVehicleSocConfiguration, vehicle: int) -> req.Session:
session = req.Session()
session = req.get_http_session()
data = {'grant_type': 'app',
'client_id': str(config.client_id),
'client_secret': str(config.client_secret)}
Expand Down
25 changes: 25 additions & 0 deletions packages/modules/vehicles/tronity/api_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import time

import jwt

from modules.common import req
from modules.vehicles.tronity.api import create_session
from modules.vehicles.tronity.config import TronityVehicleSocConfiguration


def test_create_session_uses_session_with_default_timeout():
# Ein bereits gueltiger Token vermeidet den Token-Request-Zweig (der wuerde ueber
# write_token_mqtt() einen echten Pub()/MQTT-Broker ansprechen).
valid_token = jwt.encode({"exp": time.time() + 3600}, "test-secret-key-that-is-at-least-32-bytes-long",
algorithm="HS256")
config = TronityVehicleSocConfiguration(
vehicle_id="vid", client_id="id", client_secret="secret", access_token=valid_token)

session = create_session(config, vehicle=1)

# Regression: create_session nutzte frueher eine rohe requests.Session ohne Timeout -
# dadurch konnte ein haengender Tronity-Request den SoC-Abruf dauerhaft blockieren
# (https://github.com/openWB/core/discussions/3938). Jedes andere Fahrzeugmodul nutzt
# bereits req.get_http_session() (5s Default-Timeout).
assert isinstance(session, req.CustomSession)
assert session.default_timeout == 5