Repository navigation
Leistungssumme für Verbraucher&Zähler außerhalb des Hausverbrauchs - #4030
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Register the new topic in update-config persistence and home-consumption access-control lists.
Review effort: Lite
Findings: 1
What changed in this PR
Adds calculation and publication of power consumption outside home consumption.
Changes:
- Separates home and non-home consumption totals.
- Adds MQTT validation and the
not_in_home_consumptionfield. - Expands tests for classification and fault handling.
| File | Summary |
|---|---|
packages/helpermodules/setdata.py |
Validates the new MQTT value. |
packages/control/counter_all/counter_home_consumption_test.py |
Tests split consumption calculations. |
packages/control/counter_all/counter_all.py |
Calculates home and non-home power. |
packages/control/counter_all/counter_all_data.py |
Defines the new published field; its topic still requires persistence and ACL registration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| loadmanagement_active: bool = field( | ||
| default=False, metadata={"topic": "set/loadmanagement_active"}) | ||
| home_consumption: float = field(default=0, metadata={"topic": "set/home_consumption"}) | ||
| not_in_home_consumption: float = field(default=0, metadata={"topic": "set/not_in_home_consumption"}) |
LKuemmel
marked this pull request as draft
September 29, 2026 08:51
LKuemmel
marked this pull request as ready for review
September 29, 2026 10:16
AlexanderHa98
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.