Repository navigation
Internal chargepoint handler: refactor loop contexts - #4169
Merged
Merged
Conversation
LKuemmel
force-pushed
the
feature_refactor_internal_chargepoint_handler
branch
8 times, most recently
from
October 29, 2026 08:27
50dc85c to
d77ed49
Compare
LKuemmel
force-pushed
the
feature_refactor_internal_chargepoint_handler
branch
from
October 29, 2026 08:53
d77ed49 to
da7c98a
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified, and the change is limited to context-management refactoring while preserving polling behavior and existing handling.
No open issues 🎉
What changed in this PR
Refactors internal chargepoint polling loop context management without changing polling behavior.
Changes:
- Uses
ExitStackto manage Modbus client contexts. - Deduplicates shared client connections.
- Preserves Pro Plus handling and no-client behavior.
| File | Description |
|---|---|
packages/modules/internal_chargepoint_handler/internal_chargepoint_handler.py |
Refactors loop context handling for internal chargepoint clients. |
This pull request is ready to be approved.
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.