Repository navigation
simpleAPI: Fix Einheit bei max_price_eco im MQTT-Topic - #4195
Merged
LKuemmel merged 1 commit intoOct 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain, and the change consistently applies the unit conversion to both chargepoint-specific and aggregate MQTT topics.
No open issues 🎉
What changed in this PR
This pull request fixes the max_price_eco unit published in MQTT topics, converting the internal EUR/Wh value to ct/kWh for consistency with set_max_price_eco.
Changes:
- Converts
max_price_ecoby multiplying the value by 100,000. - Applies the conversion to both chargepoint-specific and aggregate MQTT topics.
| File | Description |
|---|---|
simpleAPI/simpleAPI_mqtt.py |
Publishes max_price_eco values in ct/kWh for both MQTT topic variants. |
Review effort: Lite
seaspotter
added a commit
to seaspotter/ioBroker.openwb2
that referenced
this pull request
Oct 29, 2026
Not for release yet - gated on openWB/core#4195 actually merging and shipping. Shipping this before then would break maxPriceEco for every current user (they'd get the correct value today; this makes it read EUR/Wh * 100000 too small once the fix isn't live). openWB/core#4195 fixes max_price_eco to publish already in ct/kWh, where it previously published the raw EUR/Wh value - our adapter was compensating for that bug with its own *100000 conversion. Only the computed max_price_eco read field needs this removed. The separate set/charge_template/chargemode/eco_charging/max_price write-echo field is a raw mirror of the internal charge_template JSON (still EUR/Wh) and is untouched by that PR - confirmed by reading the full simpleAPI_mqtt.py on the PR branch, not just the diff. Co-Authored-By: Claude Sonnet 5 <[email protected]>
2 tasks done
seaspotter
added a commit
to seaspotter/ioBroker.openwb2
that referenced
this pull request
Oct 29, 2026
Fix maxPriceEco unit now that openWB/core#4195 is merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behebt #4190:
max_price_ecowurde als roher EUR/Wh-Wert statt ct/kWh publiziert, inkonsistent zuset_max_price_eco.