Repository navigation
fix Fronius: Login schlägt manchmal fehl trotz korrekter Zugangsdaten - #4199
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Approval is deferred because interoperability of both SHA256 and MD5 fallback Digest authentication with relevant Fronius firmware cannot be confirmed without a representative inverter or protocol-level integration test.
No open issues 🎉
What changed in this PR
This PR fixes intermittent Fronius authentication failures by consistently using the negotiated hash algorithm throughout HTTP Digest authentication.
Changes:
- Applies the selected algorithm to HA1, HA2, response hashing, and the authorization header.
- Preserves the existing MD5/SHA-256 fallback behavior.
| File | Description |
|---|---|
| packages/modules/devices/fronius/fronius_http_api/fronius_api.py | Aligns all Fronius Digest authentication calculations and authorization header generation with the selected hash algorithm. |
Review effort: Lite
LKuemmel
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix für: #3465 (comment)
Beim Login wurde teilweise mit zwei unterschiedlichen Hash-Verfahren gleichzeitig gerechnet, wodurch der Login fehlschlagen konnte, obwohl die Zugangsdaten stimmen. Jetzt wird durchgängig dasselbe Verfahren verwendet.
@ndrsnhs – kannst du drüberschauen, ob der Fix passt?