Repository navigation
Fix Ecoflow Stream: nun in Geräteliste auswählbar - #4229
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
An unresolved critical compatibility issue breaks existing Ecoflow Stream configurations by changing the persisted device discriminator without a migration or compatibility alias.
1 open issue
What changed in this PR
This pull request fixes Ecoflow Stream device discovery so it can be selected from the device list by aligning its device type with the module path.
Changes:
- Changes the default device type from
ecoflow_streamtostream. - Aligns configuration and runtime module discovery with the
streamdirectory. - Existing configurations using
ecoflow_streamrequire a migration or compatibility alias.
| File | Summary |
|---|---|
packages/modules/devices/ecoflow/stream/config.py |
Updates the default device type to stream. The change may break existing configurations using ecoflow_stream because runtime imports will resolve to a nonexistent module path unless migration or compatibility support is added. |
Review effort: Lite
| def __init__(self, | ||
| name: str = "Ecoflow Stream", | ||
| type: str = "ecoflow_stream", | ||
| type: str = "stream", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4214 (comment)