Repository navigation
Vehicle: Add Pleos (Hyundai/Kia/Genesis) EU Data Act API #4233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,3 +44,10 @@ def test_redact_url_credentials_with_sensitive_field_as_user_name(): | |
| # If the user name matches an entry of KNOWN_SENSITIVE_FIELDS, the field pattern applies on | ||
| # top and truncates the url. The password is removed in that case as well. | ||
| assert redact_sensitive_info("ws://token:[email protected]/v16/") == "ws://token=***REDACTED***" | ||
|
|
||
|
|
||
| def test_redact_client_secret(): | ||
| message = '{"client_id": "abc", "client_secret": "xyz"}' | ||
| expected = '{"client_id": "abc", "client_secret": "***REDACTED***"}' | ||
|
|
||
| assert redact_sensitive_info(message) == expected | ||
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| #!/usr/bin/env python3 | ||
| from datetime import datetime | ||
| import logging | ||
| import time | ||
| from typing import Optional | ||
|
|
||
| from modules.common import req | ||
| from modules.vehicles.pleos.config import PleosToken | ||
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
| BASE_URL = "https://api.pleos.ai/v1" | ||
|
|
||
| _UNIT_TO_KM = {"km": 1, "mile": 1.609344, "miles": 1.609344, "meter": 0.001, "feet": 0.0003048} | ||
|
|
||
|
|
||
| def validate_token(brand: str, client_id: str, client_secret: str, token: PleosToken) -> PleosToken: | ||
| if token.access_token is not None and time.time() < token.created_at + token.expires_in: | ||
| return token | ||
| return request_token(brand, client_id, client_secret) | ||
|
|
||
|
|
||
| def request_token(brand: str, client_id: str, client_secret: str) -> PleosToken: | ||
| response = req.get_http_session().post( | ||
| BASE_URL + "/auth/personal-token", | ||
| json={"clientId": client_id, "clientSecret": client_secret}, | ||
| headers={"Brand": brand}, | ||
| timeout=10, | ||
| ) | ||
| data = response.json().get("data", {}) | ||
| access_token = data.get("accessToken") | ||
| if not access_token: | ||
| raise Exception("Pleos: Token-Antwort enthält keinen accessToken.") | ||
| return PleosToken(access_token=access_token, expires_in=data.get("expiresIn") or 3600, | ||
| created_at=int(time.time())) | ||
|
|
||
|
|
||
| def _auth_headers(brand: str, token: PleosToken) -> dict: | ||
| return {"Brand": brand, "Authorization": "Bearer " + token.access_token} | ||
|
|
||
|
|
||
| def get_battery(brand: str, vin: str, token: PleosToken) -> dict: | ||
| response = req.get_http_session().get( | ||
| BASE_URL + f"/vehicles/{vin}/batteries", headers=_auth_headers(brand, token), timeout=10) | ||
| return response.json().get("data", {}) | ||
|
|
||
|
|
||
| def get_distance_to_empty_km(brand: str, vin: str, token: PleosToken) -> Optional[float]: | ||
| response = req.get_http_session().get( | ||
| BASE_URL + f"/vehicles/{vin}/powertrains", headers=_auth_headers(brand, token), timeout=10) | ||
| for entry in response.json().get("data", {}).get("distanceToEmpties", []): | ||
|
seaspotter marked this conversation as resolved.
Resolved
|
||
| if entry.get("type") == "EV": | ||
| return _to_km(entry.get("value"), entry.get("unit")) | ||
| return None | ||
|
|
||
|
|
||
| def get_odometer_km(brand: str, vin: str, token: PleosToken) -> Optional[float]: | ||
| response = req.get_http_session().get( | ||
| BASE_URL + f"/vehicles/{vin}/driving", headers=_auth_headers(brand, token), timeout=10) | ||
| odometer = response.json().get("data", {}).get("odometer", {}) | ||
| return _to_km(odometer.get("value"), odometer.get("unit")) | ||
|
|
||
|
|
||
| def _to_km(value, unit: str) -> Optional[float]: | ||
| try: | ||
| value = float(value) | ||
| except (TypeError, ValueError): | ||
| return None | ||
| return value * _UNIT_TO_KM.get(unit or "km", 1) | ||
|
|
||
|
|
||
| def parse_timestamp(value: Optional[str]) -> Optional[float]: | ||
| # Pleos liefert idR den letzten vom Fahrzeug gemeldeten Stand, nicht live - | ||
| # ohne diesen Zeitstempel würde CarState "jetzt" annehmen und die | ||
| # Veraltungs-/Reihenfolge-Prüfung in ConfigurableVehicle wirkungslos machen. | ||
| if not value: | ||
| return None | ||
|
sourcery-ai[bot] marked this conversation as resolved.
Resolved
|
||
| try: | ||
| return datetime.fromisoformat(value.replace("Z", "+00:00")).timestamp() | ||
| except ValueError: | ||
| return None | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| import time | ||
| from unittest.mock import Mock | ||
|
|
||
| import pytest | ||
|
|
||
| from modules.vehicles.pleos import api | ||
| from modules.vehicles.pleos.config import PleosToken | ||
|
|
||
|
|
||
| def _session_returning(payload): | ||
| session = Mock() | ||
| response = Mock() | ||
| response.json.return_value = payload | ||
| session.get.return_value = response | ||
| session.post.return_value = response | ||
| return session | ||
|
|
||
|
|
||
| class TestValidateToken: | ||
| def test_reuses_valid_token(self, monkeypatch): | ||
| session = _session_returning({}) | ||
| monkeypatch.setattr(api.req, "get_http_session", lambda: session) | ||
| token = PleosToken(access_token="cached", expires_in=3600, created_at=int(time.time())) | ||
|
|
||
| result = api.validate_token("kia", "cid", "csec", token) | ||
|
|
||
| assert result.access_token == "cached" | ||
| session.post.assert_not_called() | ||
|
|
||
| def test_requests_new_token_when_expired(self, monkeypatch): | ||
| session = _session_returning({"data": {"accessToken": "fresh", "expiresIn": 3600}}) | ||
| monkeypatch.setattr(api.req, "get_http_session", lambda: session) | ||
| token = PleosToken(access_token="old", expires_in=10, created_at=int(time.time()) - 100) | ||
|
|
||
| result = api.validate_token("kia", "cid", "csec", token) | ||
|
|
||
| assert result.access_token == "fresh" | ||
| session.post.assert_called_once() | ||
|
|
||
| def test_raises_when_no_access_token_in_response(self, monkeypatch): | ||
| session = _session_returning({"data": {}}) | ||
| monkeypatch.setattr(api.req, "get_http_session", lambda: session) | ||
|
|
||
| with pytest.raises(Exception): | ||
| api.validate_token("kia", "cid", "csec", PleosToken()) | ||
|
|
||
|
|
||
| class TestGetBattery: | ||
| def test_returns_charge_data(self, monkeypatch): | ||
| payload = {"data": {"charge": {"stateOfCharge": 72.5}}} | ||
| session = _session_returning(payload) | ||
| monkeypatch.setattr(api.req, "get_http_session", lambda: session) | ||
|
|
||
| result = api.get_battery("kia", "VIN1", PleosToken(access_token="t")) | ||
|
|
||
| assert result["charge"]["stateOfCharge"] == 72.5 | ||
|
|
||
|
|
||
| class TestGetDistanceToEmptyKm: | ||
| def test_converts_miles_to_km(self, monkeypatch): | ||
| payload = {"data": {"distanceToEmpties": [{"type": "EV", "value": "100", "unit": "mile"}]}} | ||
| session = _session_returning(payload) | ||
| monkeypatch.setattr(api.req, "get_http_session", lambda: session) | ||
|
|
||
| result = api.get_distance_to_empty_km("kia", "VIN1", PleosToken(access_token="t")) | ||
|
|
||
| assert round(result, 2) == 160.93 | ||
|
|
||
| def test_ignores_non_ev_entries(self, monkeypatch): | ||
| payload = {"data": {"distanceToEmpties": [{"type": "ICE", "value": "500", "unit": "km"}]}} | ||
| session = _session_returning(payload) | ||
| monkeypatch.setattr(api.req, "get_http_session", lambda: session) | ||
|
|
||
| assert api.get_distance_to_empty_km("kia", "VIN1", PleosToken(access_token="t")) is None | ||
|
|
||
| def test_returns_none_on_invalid_value(self, monkeypatch): | ||
| payload = {"data": {"distanceToEmpties": [{"type": "EV", "value": "invalid", "unit": "km"}]}} | ||
| session = _session_returning(payload) | ||
| monkeypatch.setattr(api.req, "get_http_session", lambda: session) | ||
|
|
||
| assert api.get_distance_to_empty_km("kia", "VIN1", PleosToken(access_token="t")) is None | ||
|
|
||
|
|
||
| class TestGetOdometerKm: | ||
| def test_returns_value_in_km(self, monkeypatch): | ||
| payload = {"data": {"odometer": {"value": "15234", "unit": "km"}}} | ||
| session = _session_returning(payload) | ||
| monkeypatch.setattr(api.req, "get_http_session", lambda: session) | ||
|
|
||
| assert api.get_odometer_km("kia", "VIN1", PleosToken(access_token="t")) == 15234.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| from typing import Optional | ||
|
|
||
|
|
||
| class PleosToken: | ||
| def __init__(self, | ||
| access_token: Optional[str] = None, | ||
| expires_in: int = 0, | ||
| created_at: int = 0) -> None: | ||
| self.access_token = access_token | ||
| self.expires_in = expires_in | ||
| self.created_at = created_at | ||
|
|
||
|
|
||
| class PleosConfiguration: | ||
| def __init__(self, | ||
| brand: Optional[str] = None, | ||
| client_id: Optional[str] = None, | ||
| client_secret: Optional[str] = None, | ||
|
sourcery-ai[bot] marked this conversation as resolved.
Resolved
|
||
| vin: Optional[str] = None, | ||
| token: Optional[PleosToken] = None) -> None: | ||
| self.brand = brand | ||
| self.client_id = client_id | ||
| self.client_secret = client_secret | ||
| self.vin = vin | ||
| self.token = token or PleosToken() | ||
|
|
||
|
|
||
| class Pleos: | ||
| def __init__(self, | ||
| name: str = "Pleos (Hyundai/Kia/Genesis)", | ||
| type: str = "pleos", | ||
| official: bool = False, | ||
| configuration: Optional[PleosConfiguration] = None) -> None: | ||
| self.name = name | ||
| self.type = type | ||
| self.official = official | ||
| self.configuration = configuration or PleosConfiguration() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| #!/usr/bin/env python3 | ||
| import logging | ||
|
|
||
| import requests | ||
|
|
||
| from modules.common.abstract_device import DeviceDescriptor | ||
| from modules.common.abstract_vehicle import VehicleUpdateData | ||
| from modules.common.component_state import CarState | ||
| from modules.common.configurable_vehicle import ConfigurableVehicle | ||
| from modules.vehicles.pleos import api | ||
| from modules.vehicles.pleos.config import Pleos | ||
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def _get_battery_with_token_refresh(config) -> dict: | ||
| try: | ||
| return api.get_battery(config.brand, config.vin, config.token) | ||
| except requests.HTTPError as e: | ||
| if e.response is None or e.response.status_code != 401: | ||
| raise | ||
| config.token = api.request_token(config.brand, config.client_id, config.client_secret) | ||
| return api.get_battery(config.brand, config.vin, config.token) | ||
|
|
||
|
|
||
| def fetch(vehicle_config: Pleos, vehicle_update_data: VehicleUpdateData) -> CarState: | ||
| config = vehicle_config.configuration | ||
| if not config.vin: | ||
| raise Exception("Pleos: VIN muss konfiguriert sein.") | ||
| config.token = api.validate_token(config.brand, config.client_id, config.client_secret, config.token) | ||
| battery = _get_battery_with_token_refresh(config) | ||
| charge = battery.get('charge', {}) | ||
| soc = float(charge['stateOfCharge']) | ||
| soc_timestamp = api.parse_timestamp(battery.get('timestamp')) | ||
| if soc_timestamp is None: | ||
| raise Exception("Pleos: Zeitstempel des Ladezustands fehlt oder ist ungültig.") | ||
| target_soc = (charge.get('targetStateOfCharge') or {}).get('standard') | ||
| warning = (f"Das Fahrzeug begrenzt die Ladung selbst auf {target_soc}%." | ||
| if target_soc and target_soc < 100 else None) | ||
| try: | ||
| range = api.get_distance_to_empty_km(config.brand, config.vin, config.token) | ||
| except Exception as e: | ||
| log.debug(f"Pleos: Reichweite nicht verfügbar: {e}") | ||
| range = None | ||
| try: | ||
| odometer = api.get_odometer_km(config.brand, config.vin, config.token) | ||
| except Exception as e: | ||
| log.debug(f"Pleos: Kilometerstand nicht verfügbar: {e}") | ||
| odometer = None | ||
| return CarState(soc=soc, range=range, soc_timestamp=soc_timestamp, odometer=odometer, warning=warning) | ||
|
|
||
|
|
||
| def create_vehicle(vehicle_config: Pleos, vehicle: int): | ||
| def updater(vehicle_update_data: VehicleUpdateData) -> CarState: | ||
| return fetch(vehicle_config, vehicle_update_data) | ||
| return ConfigurableVehicle(vehicle_config=vehicle_config, | ||
| component_updater=updater, | ||
| vehicle=vehicle) | ||
|
|
||
|
|
||
| device_descriptor = DeviceDescriptor(configuration_factory=Pleos) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.