Repository navigation
EcoFlow SimCounter: use component_config.type - #4245
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes consistently replace the legacy argument with each component’s configured type, addressing the identified active issue across the inverter, counter, and battery components.
No open issues 🎉
What changed in this PR
Updates EcoFlow Stream components to initialize SimCounter with each component’s configured type, aligning with the current API and ensuring correct simulation behavior.
Changes:
- Replaces legacy
prefixarguments withcomponent_config.type. - Applies the correction to inverter, counter, and battery components.
| File | Description |
|---|---|
packages/modules/devices/ecoflow/stream/inverter.py |
Passes the configured inverter type to SimCounter. |
packages/modules/devices/ecoflow/stream/counter.py |
Passes the configured counter type to SimCounter. |
packages/modules/devices/ecoflow/stream/bat.py |
Passes the configured battery type to SimCounter. |
Review effort: Lite
LKuemmel
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.