Repository navigation
fix: Fronius Sunspec module - #4253
Open
seaspotter wants to merge 9 commits into
Open
seaspotter wants to merge 9 commits into
seaspotter wants to merge 9 commits into
Conversation
seaspotter
force-pushed
the
fronius-sunspec-hybrid-exported-simcounter
branch
from
November 2, 2026 19:17
d0d6fc8 to
cc55eb3
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Active moderate and critical findings remain in the battery module, including unfiltered energy totals and reversed charge/discharge control bits and register writes.
3 open issues
What changed in this PR
Updates the Fronius SunSpec integration to support separate MPPT channels for battery charging and discharging, correct counter sign handling, and migrate existing battery configurations.
Changes:
- Uses simulated inverter counters and corrected Smart Meter sign conventions.
- Adds configurable charge and discharge battery MPPT channels with separate readings.
- Updates battery control handling and migrates legacy configurations to the new MPPT fields.
| File | Description |
|---|---|
| packages/modules/devices/fronius/fronius_sunspec/inverter.py | Uses simulated counters for inverter import and export values. |
| packages/modules/devices/fronius/fronius_sunspec/counter.py | Updates SunSpec power and current sign conventions. |
| packages/modules/devices/fronius/fronius_sunspec/config.py | Adds separate configurable MPPT indices for battery charging and discharging. |
| packages/modules/devices/fronius/fronius_sunspec/bat.py | Reads separate battery MPPT channels and updates battery control and energy reporting. |
| packages/helpermodules/update_config.py | Migrates existing Fronius SunSpec battery configurations to the new MPPT fields. |
Review effort: Lite
LKuemmel
requested changes
Nov 12, 2026
LKuemmel
left a comment
Contributor
There was a problem hiding this comment.
Bitte die Copilot Kommentare prüfen.
…gisters; peak-filter energy totals
Collaborator
Author
erl :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


UI: openWB/openwb-ui-settings#1155
Offenbar lässt sich das Modbus Register nicht korrekt auslesen: #3465 (reply in thread)
Für die Batterie gibt es 2 MPPT Kanäle für Laden und Entladen
Summary by Sourcery
Correct Fronius SunSpec measurements and battery control for devices that expose charging and discharging through separate MPPT channels.
New Features:
Bug Fixes:
Enhancements: