Repository navigation
Internal chargepoint handler: refactor loop contexts - #4256
Merged
Merged
Conversation
LKuemmel
force-pushed
the
feature_refactor_internal_chargepoint_handler
branch
from
November 3, 2026 13:44
da7c98a to
3e0f77c
Compare
tpd-opitz
reviewed
Nov 3, 2026
Comment on lines
+172
to
179
| if not clients: | ||
| log.error("Kein ClientHandler vorhanden. Beende.") | ||
| return | ||
|
|
||
| with ExitStack() as stack: | ||
| for client in clients: | ||
| stack.enter_context(client) | ||
| _loop() |
Contributor
There was a problem hiding this comment.
sollte der loop nicht auch nur laufen, wenn es clients gibt?
Suggested change
| if not clients: | |
| log.error("Kein ClientHandler vorhanden. Beende.") | |
| return | |
| with ExitStack() as stack: | |
| for client in clients: | |
| stack.enter_context(client) | |
| _loop() | |
| if not clients: | |
| log.error("Kein ClientHandler vorhanden. Beende.") | |
| else: | |
| with ExitStack() as stack: | |
| for client in clients: | |
| stack.enter_context(client) | |
| _loop() |
Contributor
Author
There was a problem hiding this comment.
Nein, weil die Pro+ per HTTP-Request abgefragt wird und daher keinen Client braucht. Nur wenn es keine Pro+ ist und kein Modbus-Client initialisiert werden konnte, braucht die Loop nicht zu starten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.