Skip to content

Colors theme (display): Add Soc reload button - #4279

Merged
benderl merged 6 commits into
openWB:masterfrom
cshagen:update-display-2611
Nov 9, 2026
Merged

benderl merged 6 commits into
openWB:masterfrom
cshagen:update-display-2611

Conversation

@cshagen

@cshagen cshagen commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator
  • Neuer Button im Display-Theme zum manuellen Laden des SoC

Summary by Sourcery

Add manual SoC reloading to the Colors display theme and improve handling of unavailable vehicle data.

New Features:

  • Add a manual SoC reload control for configured vehicles, with a loading state while the update is pending.

Bug Fixes:

  • Handle missing SoC values safely across vehicle displays and updates.
  • Automatically register previously unknown counter messages before updating their names.

Enhancements:

  • Limit connected-vehicle selections to visible vehicles and remove debug logging.

@sourcery-ai

sourcery-ai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Data structures

Make a vehicle's SoC explicitly unavailable when its connected vehicle has no SoC value, and expose whether a vehicle should be shown.

  • packages/modules/display_themes/colors/source/src/components/chargePointList/model.ts L83-87, L394-399

Implementation

Register counters that are first encountered through a system counter configuration message.

  • packages/modules/display_themes/colors/source/src/assets/js/processMessages.ts L235-237

Remove temporary debug logging from the radio input and charge-point configuration logic.

  • packages/modules/display_themes/colors/source/src/components/chargePointList/configPanels/ChargeConfig.vue L95
  • packages/modules/display_themes/colors/source/src/components/shared/RadioInput.vue L33 (removed lines)

UI

Add a manual SoC reload control with a pending indicator, and safely handle missing SoC values in the vehicle display.

  • packages/modules/display_themes/colors/source/src/components/chargePointList/VehicleData.vue L58-66, L171-174, L242-245 (+3 small edits)

Default an unavailable SoC to zero when rendering the power meter.

  • packages/modules/display_themes/colors/source/src/components/powerMeter/PowerMeter.vue L261

Configuration

Limit the connected-vehicle selector to vehicles marked visible, hiding invalid or zombie entries.

  • packages/modules/display_themes/colors/source/src/components/chargePointList/configPanels/ChargeConfig.vue L11

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="packages/modules/display_themes/colors/source/src/components/chargePointList/VehicleData.vue" line_range="61" />
<code_context>
+				<DisplayButton v-else >
+					<i
+						class="fa-solid fa-sm fas fa-sync py-0 px-3 mt-3"
+						:class="chargepoint.waitingForSoc ? 'fa-spinner fa-spin' : 'fa-sync'"
+					@click="loadSoc"
+						:style="{ color: 'var(--color-fg)' }"
</code_context>
<issue_to_address>
**Loading indicator stays a sync icon**

When a SoC reload is pending, the static `fa-sync` class remains on the icon while the conditional class adds `fa-spinner`; both Font Awesome classes define the icon glyph, so the reload-in-progress state can continue showing the sync glyph instead of the spinner.

Remove `fa-sync` from the static class and add it only in the non-loading branch of the conditional class.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@benderl
benderl merged commit 0e0d6ba into openWB:master Nov 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants