Repository navigation
Colors theme (display): Add Soc reload button - #4279
Merged
Merged
Conversation
Reviewer's GuideData structuresMake a vehicle's SoC explicitly unavailable when its connected vehicle has no SoC value, and expose whether a vehicle should be shown.
ImplementationRegister counters that are first encountered through a system counter configuration message.
Remove temporary debug logging from the radio input and charge-point configuration logic.
UIAdd a manual SoC reload control with a pending indicator, and safely handle missing SoC values in the vehicle display.
Default an unavailable SoC to zero when rendering the power meter.
ConfigurationLimit the connected-vehicle selector to vehicles marked visible, hiding invalid or zombie entries.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="packages/modules/display_themes/colors/source/src/components/chargePointList/VehicleData.vue" line_range="61" />
<code_context>
+ <DisplayButton v-else >
+ <i
+ class="fa-solid fa-sm fas fa-sync py-0 px-3 mt-3"
+ :class="chargepoint.waitingForSoc ? 'fa-spinner fa-spin' : 'fa-sync'"
+ @click="loadSoc"
+ :style="{ color: 'var(--color-fg)' }"
</code_context>
<issue_to_address>
**Loading indicator stays a sync icon**
When a SoC reload is pending, the static `fa-sync` class remains on the icon while the conditional class adds `fa-spinner`; both Font Awesome classes define the icon glyph, so the reload-in-progress state can continue showing the sync glyph instead of the spinner.
Remove `fa-sync` from the static class and add it only in the non-loading branch of the conditional class.
</issue_to_address>
benderl
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add manual SoC reloading to the Colors display theme and improve handling of unavailable vehicle data.
New Features:
Bug Fixes:
Enhancements: