Skip to content

consumer fix generic JSON consumer - #4295

Merged
LKuemmel merged 1 commit into
openWB:masterfrom
seaspotter:fix-generic-json-consumer-temperatures-none-list
Nov 11, 2026
Merged

LKuemmel merged 1 commit into
openWB:masterfrom
seaspotter:fix-generic-json-consumer-temperatures-none-list

Conversation

@seaspotter

@seaspotter seaspotter commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Don't publish temperatures=[None] when jq_temperatures is unset

Summary by Sourcery

Preserve absent temperature data as None while retaining list-wrapped values when temperatures are configured.

Bug Fixes:

  • Prevent the generic JSON consumer from publishing an invalid [None] temperatures payload when temperature extraction is not configured.

Tests:

  • Add coverage for omitted temperature configuration and configured temperature values.

@sourcery-ai

sourcery-ai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Implementation

Preserve None when the JSON consumer has no temperature value, while wrapping a configured scalar temperature in a list.

  • packages/modules/consumers/generic/json/consumer.py L70-72

Tests

Verify unset temperatures remain None and configured temperatures are returned as a list.

  • packages/modules/consumers/generic/json/consumer_test.py L1-38

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@LKuemmel
LKuemmel merged commit fe34ebc into openWB:master Nov 11, 2026
2 checks passed
@seaspotter
seaspotter deleted the fix-generic-json-consumer-temperatures-none-list branch November 11, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants