Repository navigation
feat(api): support audio fixture playback in Live sessions - #4085
Conversation
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 40 mixed files remain; 0 existing customizations changed; 3 generated baselines changed. Compared
37 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38813705843 --repo openai/openai-python \
--name castiron-custom-code-38813705843-1 --dir /tmp/castiron-custom-code-38813705843-1
git apply --stat /tmp/castiron-custom-code-38813705843-1/custom-code.patch
cat /tmp/castiron-custom-code-38813705843-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin e71d781ac5e7b3f365ac130bf338baaf13ae720d a9a8c5eb841f3c779112f0a42b3daace8bc8d273
python3 scripts/castiron/custom_code_report.py report \
--base e71d781ac5e7b3f365ac130bf338baaf13ae720d \
--head a9a8c5eb841f3c779112f0a42b3daace8bc8d273 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-a9a8c5eb841f
cat /tmp/castiron-custom-code-a9a8c5eb841f/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b036e70bdb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Castiron-Internal-PR: openai/openai-python-internal#257 Castiron-Source-SHA: 3c683a02b15cfe933a1273c629f19eb5b73799a3 Castiron-Public-Base-SHA: e71d781
b036e70 to
a9a8c5e
Compare
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed the full 22-file diff at a9a8c5e. No blocking issues found.
The earlier queue-limit concern is addressed across sync/async primary, fork, and sideband connections: the Live-only 2 MiB default accommodates the documented 30-second fixture payload, while explicit caller-supplied queue budgets remain intact. I also checked event discriminators/unions, helper serialization, and the unchanged no-replay behavior on failed sends.
Static source/security review only; no local tests or live API calls were run. Current hosted checks are green, and I inspected the successful Python 3.10/3.14 test logs.
3 participants
Summary
Send an audio fixture in a Live session and handle the fixture acceptance and playback events.
Changes
session.output_audio.fixture.play.session.output_audio.fixture.playingwhen the server accepts the audio, and correlate it with the play event usingclient_event_id.session.output_audio.fixture.playedwhen the server mixer drains. Audio buffered by the transport may still be playing.