Repository navigation
fix(api): honor per-call WebSocket query settings - #4138
Conversation
Castiron custom codeEvaluated main: Trusted main policy: Mixed files: 42 → 46 4 newly customized · 0 customizations removed · 0 existing customizations changed · 14 generated baselines changed Compared
32 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 39675509168 --repo openai/openai-python \
--name castiron-custom-code-39675509168-1 --dir /tmp/castiron-custom-code-39675509168-1
git apply --stat /tmp/castiron-custom-code-39675509168-1/custom-code.patch
cat /tmp/castiron-custom-code-39675509168-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 26e5d926966fc5c7e688790b21d66dc08d35eceb 35a224c58d1ea2a9af31336061c846b9ead5c938
python3 scripts/castiron/custom_code_report.py report \
--base 26e5d926966fc5c7e688790b21d66dc08d35eceb \
--head 35a224c58d1ea2a9af31336061c846b9ead5c938 --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-35a224c58d1e
cat /tmp/castiron-custom-code-35a224c58d1e/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
b0306dc to
ab1a857
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab1a857c61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Coordinator and independent static review found no actionable issues. Checked logical default removal before serialization, omit/None and structured values, preservation of untouched repeated URL values, Azure required settings, and managed Translation query propagation through connection/recovery paths. The existing raw-bracket-key finding is consistent with the documented author explanation and HTTP literal-key behavior; no additional change is required for it.
All substantive hosted checks passed, including OkTest. No candidate code or tests were run locally.
ab1a857 to
f842807
Compare
|
@codex review |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Re-approved after coordinator and independent static re-review. Exact full-tree comparison against the previously approved ab1a857 confirms only two changed helper files. The multi_items filters preserve exact-key removal and untouched repeated query values while replacing repeated removal loops. No actionable issues found.
All substantive hosted checks passed. No candidate code or tests were run locally.
Castiron-Internal-PR: openai/openai-python-internal#303 Castiron-Source-SHA: df11e60f60ebe9acf1cab6c741b66322b11e53b0 Castiron-Public-Base-SHA: 26e5d92
f842807 to
35a224c
Compare
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Re-reviewed 35a224c against previously approved f842807, including an independent static review. No blocking issues found. The new behavior preserves historical per-call blank values for None and repeated keys for lists/tuples, while defaults retain REST encoding. It copies the mapping and sequences before normalization. Existing omission, logical-default replacement, and exact raw-URL key behavior remain intact; WebSocket adapters and managed Translation code are byte-identical to the prior approved version. Regression cases cover blank values, list/tuple items, defaults, and managed Translation.
Hosted CI, including OkTest, is still running; no failures observed. No candidate code or tests were run locally.
Automated Release PR --- ## [3.36.1](openai/openai-python@v3.36.0...v3.36.1) (2026-10-22) ### Bug Fixes * **api:** honor per-call WebSocket query settings ([openai#4138](openai#4138)) ([d40a5e1](openai@d40a5e1)) * **examples:** stop microphone capture between recordings ([openai#4143](openai#4143)) ([26e5d92](openai@26e5d92)) * validate browser calls before reading driver state ([openai#4142](openai#4142)) ([2bfe460](openai@2bfe460)) ### Chores * **api:** clarify service-account API key deletion ([openai#4151](openai#4151)) ([6ed945e](openai@6ed945e)) ### Refactors * prepare handwritten chunked upload runtime ([openai#4146](openai#4146)) ([2d58e82](openai@2d58e82)) * prepare handwritten vector-store polling runtime ([openai#4148](openai#4148)) ([7cd7028](openai@7cd7028)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
WebSocket connections now honor per-call query settings across Realtime, Translation, Live, and stable/Beta Responses, including omitted keys and nested values.
The fix preserves released behavior: explicit
Nonestays blank, per-call lists and tuples use repeated keys, and untouched repeated URL values remain intact. Client defaults retain their existing HTTP query encoding. Azure Realtime keeps its required API version and deployment settings.The Translation close-worker regression also waits for its local peer to start before testing startup failure.
Validation: 186 focused checks pass, along with type and lint checks. Current-head CI passes, including OkTest, and all review threads are resolved.