Repository navigation
Dictionary fixtures move to per-dictionary data repositories - #41
Merged
Merged
Conversation
…ata repos The gem is the implementation: dictionary fixtures are data and live in per-dictionary repositories (data-oceanrunner, data-scenicspots, data-antiques, data-poi). spec_helper resolves them from a sibling checkout when present and otherwise caches a download from the public repository, so CI coverage is preserved without sibling checkouts. A poi_spec covers the registry dictionary; the ScenicSpots specs assert the curated learning dictionary again. Docs and README link to the data repositories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Per-dictionary data repositories: the gem is an implementation, not a data host.
Test plan