Skip to content

Specs for the one-real-dataset scenicspots registry - #42

Merged
ronaldtse merged 1 commit into
mainfrom
real-dataset-specs
Oct 9, 2026
Merged

ronaldtse merged 1 commit into
mainfrom
real-dataset-specs

Conversation

@ronaldtse

Copy link
Copy Markdown
Contributor

What

  • scenicspots_spec asserts the full 804-entity real registry (620+ individuals, 32 P757-graded World Heritage sites); poi_spec removed.
  • antiques counts updated for the Met title dedupe (146 entities).

Why

One real dataset per dictionary — the real dataset is the teacher.

Test plan

  • bundle exec rspec — 1009 examples, 0 failures.

The poi dictionary merges back — an incomplete curated subset is not
a teacher; the real dataset is. scenicspots_spec asserts the full
804-entity registry (620+ SPI individuals, 32 UNESCO World Heritage
grades from P757 claims); poi_spec is gone; antiques counts reflect
the Met title dedupe (146).
@ronaldtse
ronaldtse merged commit 852fe1c into main Oct 9, 2026
@ronaldtse
ronaldtse deleted the real-dataset-specs branch October 9, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant