Repository navigation
test(tls): qualify constructor sessions and resumed peer certificates - #39
Draft
vincentkoc wants to merge 3 commits into
Draft
vincentkoc wants to merge 3 commits into
vincentkoc wants to merge 3 commits into
Conversation
vincentkoc
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prove the Node TLS constructor-session repair required by the fork integration. This branch carries secretless native proof controls; it does not publish a Node contribution or change consumer pins.
Direct TLSSocket construction now uses the existing session-validation owner, including transport identity and handle reinitialization. A resumed client with no peer chain obtains an owned peer-certificate reference so certificate/hostname inspection remains available.
Native qualification passed: https://github.com/openclaw/WebKit/actions/runs/41210960096 at
f3ac2591232e8fb29e294100eb8bcaa7bed107fc, against frozen Noded44625a4b80c672215b469906ce583ce7eeeebaf. The fresh Linux x64 build passed all 80 unique constructor cases plus two real TLS fallback cases and five TLS test files, including the constructor regression and repeated certificate reads. No skips, errors or timeouts. The admitted prior native baseline reproduced the original resumption failure; only its validated baseline evidence was reused from that failed overall run.Artifact13049812810: ZIP SHA-256
ea855f801df1d22cec29bc5606749e1e76af0d01ef3aad139d3ba18c21e47cab; inner TAR SHA-2563543fa4b1c732397ab4530fc210a56d6c426633e4fef8abb5c3e607b624acbcb. All 12 inner manifest entries verified. Fixture SHA-25679df13f16ff4954e2084add3b9c07e25cfc545f2d12924648468558e7d3b11ea; patch SHA-2567cb5ac11dca77da91f683dbfa4d63b1da48f5952bba71c17d57e38bce455e72e. Patched executable SHA-256dda3a48e13fde16a2f7b66249a721cd2db428e42c03454c5ffabbbe63e0327a2and embedded TLS wrapper identity matched the measured patched sources.This is focused Linux proof, not full Node CI or cross-platform qualification. Upstream submission requires human source/test review, DCO sign-off and assistance disclosure under Node’s frozen contribution rules. A concrete patch, regression fixture and submission handoff are prepared; no Node fork, PR, issue, comment or push has been created.