Skip to content

feat: run the decomposed drivers on foreign metadata via metadata_prefix - #3670

Merged
fschade merged 2 commits into
opencloud-eu:mainfrom
fschade:feat-decomposedfs-metadata-prefix
Oct 9, 2026
Merged

fschade merged 2 commits into
opencloud-eu:mainfrom
fschade:feat-decomposedfs-metadata-prefix

Conversation

@fschade

@fschade fschade commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Description

Adds metadata_prefix to the decomposed, decomposeds3 and storage-system drivers, for trees whose node metadata doesn't use user.oc..

New env vars:

  • OC_METADATA_PREFIX (set the prefix)

Motivation and Context

Allow to use similar FS with a custom prefix

How Has This Been Tested?

  • local installation & tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added

Comment thread go.mod Outdated
@fschade
fschade marked this pull request as draft October 6, 2026 16:03
@codacy-production

codacy-production Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

🟢 Coverage 80.00% diff coverage · +0.48% coverage variation

Metric Results
Coverage variation ✅ +0.48% coverage variation (-1.00%)
Diff coverage ✅ 80.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (84e10b3) 91169 22411 24.58%
Head commit (d4ccf05) 91179 (+10) 22847 (+436) 25.06% (+0.48%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3670) 10 8 80.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@fschade
fschade requested review from aduffeck and micbar October 7, 2026 19:18
@fschade
fschade marked this pull request as ready for review October 7, 2026 19:19
@fschade
fschade force-pushed the feat-decomposedfs-metadata-prefix branch from 6eabc39 to 1b891f8 Compare October 8, 2026 07:48
# Conflicts:
#	go.sum
#	vendor/github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs/decomposedfs.go
#	vendor/github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs/options/options.go
#	vendor/modules.txt
@fschade
fschade force-pushed the feat-decomposedfs-metadata-prefix branch from 1b891f8 to db8c970 Compare October 9, 2026 12:45
@fschade
fschade force-pushed the feat-decomposedfs-metadata-prefix branch from db8c970 to d4ccf05 Compare October 9, 2026 12:49
@fschade
fschade merged commit 369d386 into opencloud-eu:main Oct 9, 2026
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants