Skip to content

test: retry acceptance requests while share manager is migrating - #3681

Merged
saw-jan merged 1 commit into
mainfrom
fix/acceptance-retry-on-share-manager-migrating
Oct 9, 2026
Merged

saw-jan merged 1 commit into
mainfrom
fix/acceptance-retry-on-share-manager-migrating

Conversation

@v-scharf

@v-scharf v-scharf commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Problem:

right after server startup or restart (using oc_wrapper), the jsoncs3 share manager runs data migrations. While they run, any write to the share manager is rejected with 500 and body error creating share: error: aborted: share manager is currently migrating, please retry

example: https://ci.opencloud.rocks/repos/3/pipeline/3977/281

==> REQUEST [2026-10-08T10:34:01]
		POST /graph/v1beta1/drives/c6b828e8-d269-48da-b237-dd84e5e4368a$612ed9f5-f46c-4533-babf-4184603a0c4f/items/c6b828e8-d269-48da-b237-dd84e5e4368a$612ed9f5-f46c-4533-babf-4184603a0c4f!c02975b0-c765-4249-ac1e-6f69f7f12c78/invite
		X-Request-ID: apiSharingNgAdditionalShareRole/listGrantsShareRole.feature:1044-1031
		==> REQ BODY
		{"recipients":[{"@libre.graph.recipient.type":"user","objectId":"08c4dd63-d6a0-4cb2-bbdd-a5fec624a319"}],"roles":["e8ea8b21-abd4-45d2-b893-8d1546378e9e"]}

		<== RESPONSE [2026-10-08T10:34:01]
		500 Internal Server Error
		X-Xss-Protection: 1; mode=block
		<== RES BODY
		{"error":{"code":"generalException","innererror":{"date":"2026-10-08T10:34:01Z","request-id":"apiSharingNgAdditionalShareRole/listGrantsShareRole.feature:1044-1031"},"message":"error creating share: error: aborted: share manager is currently migrating, please retry"}}

It was already fixed for creating share 0efe09f

but still failed for creating space because creating a space also creates a space-member grant via the share manager

Solution:

Moved the retry into a single HttpRequestHelper::sendRequest reusing its existing retry loop (which already retries 425 Too Early and 409 Conflict)

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@v-scharf
v-scharf force-pushed the fix/acceptance-retry-on-share-manager-migrating branch from 0d5994c to b6775a1 Compare October 8, 2026 12:28
@saw-jan
saw-jan merged commit 658a782 into main Oct 9, 2026
59 checks passed
@saw-jan
saw-jan deleted the fix/acceptance-retry-on-share-manager-migrating branch October 9, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants