Repository navigation
test: retry acceptance requests while share manager is migrating - #3681
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
v-scharf
force-pushed
the
fix/acceptance-retry-on-share-manager-migrating
branch
from
October 8, 2026 12:28
0d5994c to
b6775a1
Compare
saw-jan
approved these changes
Oct 9, 2026
1 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
right after server startup or restart (using
oc_wrapper), thejsoncs3 share managerruns data migrations. While they run, any write to the share manager is rejected with 500 and bodyerror creating share: error: aborted: share manager is currently migrating, please retryexample: https://ci.opencloud.rocks/repos/3/pipeline/3977/281
It was already fixed for creating share 0efe09f
but still failed for creating space because creating a space also creates a space-member grant via the share manager
Solution:
Moved the retry into a single
HttpRequestHelper::sendRequestreusing its existing retry loop (which already retries 425 Too Early and 409 Conflict)