Skip to content

fix: preserve CCX and multipart problem identities. - #182

Open
anfbermudezme wants to merge 1 commit into
openedx:mainfrom
Pearson-Advance:felipeb/fix-ccx-problem-identifiers
Open

anfbermudezme wants to merge 1 commit into
openedx:mainfrom
Pearson-Advance:felipeb/fix-ccx-problem-identifiers

Conversation

@anfbermudezme

@anfbermudezme anfbermudezme commented Oct 27, 2026 •

Copy link
Copy Markdown

Description

Positional parsing of CCX identifiers assigns the same block_id_short to different questions. Because reporting tables use that value in their replacement keys, distinct results and response groups can collapse during ClickHouse merges.

Changes

  • Extract short block IDs using the +block@ delimiter.
  • Expose problem_id in dim_problem_results and dim_problem_responses, and use it in their replacement keys and response grouping.
  • Apply the same short-ID extraction fix to dim_subsection_problem_results.
  • Add focused regression tests and document reconstruction of the three affected models.

Testing

  • 14 targeted dbt tests passed, including normal courses, five distinct CCX questions, two learners, two CCX classes, and identical responses across questions.
  • Isolated ClickHouse 25.8 tests passed: the original keys collapse five CCX questions to one; the corrected models retain all five after merges. Multiple insertion batches and full-batch replay matched independent source queries.
  • dbt parsing, compilation, and SQL formatting checks passed.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 27, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @anfbermudezme!

This repository is currently maintained by @openedx/committers-analytics.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@anfbermudezme
anfbermudezme force-pushed the felipeb/fix-ccx-problem-identifiers branch from cd1a0d2 to 7edfc8a Compare October 27, 2026 19:56
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Oct 27, 2026
@mphilbrick211
mphilbrick211 requested a review from a team October 27, 2026 20:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

2 participants