Skip to content

fix: backport engagement and video fixes (#177, #180) to ulmo - #183

Open
bmtcril wants to merge 7 commits into
release/ulmofrom
backport/ulmo-engagement-perf
Open

bmtcril wants to merge 7 commits into
release/ulmofrom
backport/ulmo-engagement-perf

Conversation

@bmtcril

@bmtcril bmtcril commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Backports #177 and #180 to release/ulmo (currently v6.1.0, the version Aspects v3.x pins), for openedx/tutor-contrib-aspects#1374 (epic openedx/tutor-contrib-aspects#1373).

Commits

  1. Video segment pairing fix #177: pair video play/end events in the refreshable fact_video_watch_intervals. fact_video_segments and fact_video_engagement become views over it.
  2. perf: fix engagement chart numbers and improve video chart performance #180: correct engagement chart numbers and faster video/engagement models.
  3. CI: pin tutor-contrib-aspects>=3.0.3,<4 in coverage.yml. Unpinned, CI on this branch installs Aspects v6 and tests against v6's schema instead of v3's.

Conflicts resolved

The files #177/#180 touch now match v8.1.0, except:

  • dim_course_blocks.sql: ulmo uses the section_from_display / subsection_from_display macros, v8 inlines the same expressions
  • models/problems/*, remove_deprecated_models.sql: ulmo still has dim_subsection_performance and the problem_events-based test input

Checked locally

  • sqlfmt models macros --check: 73 files pass
  • dbt parse (dbt 1.9.11, dbt-clickhouse 1.9.4, same as v8.1.0): every ref and macro resolves
  • The only sources used are event_sink.course_blocks and course_overviews, which exist in Aspects v3
  • New env_vars (ASPECTS_VIDEO_WATCH_INTERVALS_*, ASPECTS_COURSE_STRUCTURE_REFRESH) all have defaults. Aspects v3 doesn't set them, so the defaults apply until the companion tutor-contrib-aspects change lands.
  • Aspects v3's watched_video_segments.sql already does sum(watch_count), so it stays correct with Video segment pairing fix #177's one-row-per-second segments

CI (coverage.yml) is the real end-to-end check against Aspects v3.

Release

After merge, this needs a tag for Aspects v3 to pin. v6.1.1 already exists on main and isn't in this branch, so the next tag here needs a decision: v6.1.2, which wouldn't include v6.1.1's grade-bucket fix, or v6.2.0.

🤖 Generated with Claude Code

Tycho Hob and others added 3 commits October 27, 2026 18:08
Backport of #177 (5ec07ef) to the ulmo line. fact_video_segments and
fact_video_engagement become views over the new refreshable
fact_video_watch_intervals, so play/pause pairs that arrive in different
inserts are no longer lost. Needs ClickHouse 24.10 or later.

(cherry picked from commit 5ec07ef)
Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ngagement models

Backport of #180 (49033f6) to the ulmo line. Fixes engagement chart
numbers (section totals, duplicate fact_problem_engagement rows, deleted
units, emission_time_long precision) and makes the video charts fast
enough not to run ClickHouse out of memory.

(cherry picked from commit 49033f6)
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Tycho Hob and others added 4 commits October 28, 2026 08:52
The latest images carry Aspects v6 and xapi-db-load 3.x, which can't
read the test-data config the v3 plugin renders.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Aspects v3 and its images target Ulmo; an unpinned install pulls
Tutor 22 (Verawood).

Co-Authored-By: Claude Opus 5.5 <[email protected]>
dim_course_names can hold courses with no name yet; picking one of those
made the check fail to unpack the row.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
The dictionary can still hold what it loaded while dbt was rebuilding
course_overviews, which left it empty.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant