Repository navigation
Conversation
Backport of #177 (5ec07ef) to the ulmo line. fact_video_segments and fact_video_engagement become views over the new refreshable fact_video_watch_intervals, so play/pause pairs that arrive in different inserts are no longer lost. Needs ClickHouse 24.10 or later. (cherry picked from commit 5ec07ef) Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ngagement models Backport of #180 (49033f6) to the ulmo line. Fixes engagement chart numbers (section totals, duplicate fact_problem_engagement rows, deleted units, emission_time_long precision) and makes the video charts fast enough not to run ClickHouse out of memory. (cherry picked from commit 49033f6) Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
2 tasks
The latest images carry Aspects v6 and xapi-db-load 3.x, which can't read the test-data config the v3 plugin renders. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Aspects v3 and its images target Ulmo; an unpinned install pulls Tutor 22 (Verawood). Co-Authored-By: Claude Opus 5.5 <[email protected]>
dim_course_names can hold courses with no name yet; picking one of those made the check fail to unpack the row. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The dictionary can still hold what it loaded while dbt was rebuilding course_overviews, which left it empty. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #177 and #180 to
release/ulmo(currentlyv6.1.0, the version Aspects v3.x pins), for openedx/tutor-contrib-aspects#1374 (epic openedx/tutor-contrib-aspects#1373).Commits
fact_video_watch_intervals.fact_video_segmentsandfact_video_engagementbecome views over it.tutor-contrib-aspects>=3.0.3,<4incoverage.yml. Unpinned, CI on this branch installs Aspects v6 and tests against v6's schema instead of v3's.Conflicts resolved
README.rst: kept Video segment pairing fix #177's Breaking Changes note and dropped the v7.0.0ASPECTS_RAW_XAPI_TABLEparagraph (fix: use ASPECTS_RAW_XAPI_TABLE as source for xapi events #164), which isn't on this linefact_pageview_engagement.sql,fact_video_engagement.sql: took perf: fix engagement chart numbers and improve video chart performance #180's version. Both files were rewritten there, and the only conflict was alias renamesunit-test-seeds/problems/seeds.yaml: kept bothdim_subsection_performance_expected(ulmo) andfact_learner_problem_attempts_expected(perf: fix engagement chart numbers and improve video chart performance #180)The files #177/#180 touch now match
v8.1.0, except:dim_course_blocks.sql: ulmo uses thesection_from_display/subsection_from_displaymacros, v8 inlines the same expressionsmodels/problems/*,remove_deprecated_models.sql: ulmo still hasdim_subsection_performanceand theproblem_events-based test inputChecked locally
sqlfmt models macros --check: 73 files passdbt parse(dbt 1.9.11, dbt-clickhouse 1.9.4, same as v8.1.0): every ref and macro resolvesevent_sink.course_blocksandcourse_overviews, which exist in Aspects v3env_vars (ASPECTS_VIDEO_WATCH_INTERVALS_*,ASPECTS_COURSE_STRUCTURE_REFRESH) all have defaults. Aspects v3 doesn't set them, so the defaults apply until the companion tutor-contrib-aspects change lands.watched_video_segments.sqlalready doessum(watch_count), so it stays correct with Video segment pairing fix #177's one-row-per-second segmentsCI (
coverage.yml) is the real end-to-end check against Aspects v3.Release
After merge, this needs a tag for Aspects v3 to pin.
v6.1.1already exists on main and isn't in this branch, so the next tag here needs a decision:v6.1.2, which wouldn't include v6.1.1's grade-bucket fix, orv6.2.0.🤖 Generated with Claude Code