Repository navigation
feat: add optional ordering param to exam query functions - #1324
brianjbuck-wgu wants to merge 4 commits into
Conversation
|
Thanks for the pull request, @brianjbuck-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @brianjbuck-wgu! Is this still in progress? |
Hi @mphilbrick211, Yes, let me keep this one open and put it on the schedule next week to finish up. |
7758d54 to
3776a7e
Compare
|
Hi @mphilbrick211, I've rebased this onto master. Who would be a good option to tag for review on this repo? |
|
@openedx/axim-engineering would someone be able to take a look at this for us? Thanks! |
|
@openedx/axim-engineering Can I get a review on this PR? 🙏 |
feanil
left a comment
There was a problem hiding this comment.
A couple of small things and a rebase before we can land this. Also the PR title still say "WIP" is that still true?
Address review feedback: ordering is now passed to order_by(*ordering) so callers can forward DRF's ordering list directly. A bare string is still accepted as a single field. Document the ordering argument on all four public API functions.
3776a7e to
b94310b
Compare
|
Hi @feanil, I was out of town last week. I've updated the PR and rebased onto upstream/master so this should be ready to go again. |
Description:
Fixes: #1320
JIRA:
XXX-XXXX
Pre-Merge Checklist:
edx_proctoring/__init__.pyandpackage.jsonif these changes are to be released.CHANGELOG.rstPost-Merge: