Skip to content

Remove Syria from the default embargoed country codes - #1034

Open
omaralbeik wants to merge 2 commits into
openedx:mainfrom
omaralbeik:remove-syria-openedx
Open

omaralbeik wants to merge 2 commits into
openedx:mainfrom
omaralbeik:remove-syria-openedx

Conversation

@omaralbeik

Copy link
Copy Markdown

Description:
The default EMBARGOED_COUNTRY_CODES includes SY, so enterprise checkout refuses customers in Syria unless a deployment overrides it.

Syria isn't under a US embargo anymore. The US ended the Syria sanctions program on July 1, 2025 (EO 14312), and OFAC removed the Syrian Sanctions Regulations in August 2025. Russia and Belarus look like a separate policy choice, so this only removes SY from the default and from the example in the comment.

Jira:
N/A

Merge checklist:

  • ./manage.py makemigrations has been run
    • No model changes, so there's nothing to migrate.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 12, 2026
@openedx-webhooks

openedx-webhooks commented Oct 12, 2026 •

Copy link
Copy Markdown

Thanks for the pull request, @omaralbeik!

This repository is currently maintained by @openedx/2u-enterprise.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T08:29:23.174435Z 742b0fb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 742b0fb8b0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread enterprise_access/settings/base.py Resolved
@omaralbeik

Copy link
Copy Markdown
Author

@openedx/cla-problems I submitted the contributor agreement form on October 12 but haven't received the DocuSign email yet. Could you check on it?

@mphilbrick211

Copy link
Copy Markdown

Hi @omaralbeik! Welcome! In order to get this reviewed for you, you'll need to submit a CLA form. If you are contributing as an individual, please fill out the individual CLA form here.

If you are contributing on behalf of an organization, please have your manager reach out to [email protected] so you may be added to your org's existing entity agreement.

Please let me know if you have any questions. Thanks!

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 22, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Oct 22, 2026
@omaralbeik

Copy link
Copy Markdown
Author

Thanks @mphilbrick211, I've signed the individual CLA now.

@omaralbeik
omaralbeik force-pushed the remove-syria-openedx branch from f22624b to c3a41b8 Compare October 25, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs test run Author's first PR to this repository, awaiting test authorization from Axim open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Tests Run or CLA Signed

Development

Successfully merging this pull request may close these issues.

3 participants