Repository navigation
test: fix flaky forced redemption assignment test - #1043
irfanuddinahmad wants to merge 1 commit into
Conversation
AssignedLearnerCreditAccessPolicyFactory picks a random spend_limit between 1 and 9999 cents. test_force_redemption_with_assignment_happy_path redeems a 200-cent course, so about 2% of runs got a limit below the price and failed with policy_spend_limit_reached. Give the helper a fixed spend_limit, as the per-learner tests in this file already do. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Thanks for the pull request, @irfanuddinahmad! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
test_force_redemption_with_assignment_happy_pathfails about 2% of the time withFailed forced redemption: policy_spend_limit_reached.AssignedLearnerCreditAccessPolicyFactorypicks a randomspend_limitbetween 1 and 9999 cents, and the test redeems a 200-cent course, so a limit under 200 fails the redemption. This gives the test's_new_assignment_budgethelper a fixedspend_limit=10000, the same value the per-learner tests in this file pass.Seen on #1015 (job 123883360276); a rerun of the same commit passed.
Testing:
test_forced_redemption.pypasses with the fix (4 passed). Forcingspend_limit=150reproduces the CI failure.🤖 Generated with Claude Code