Skip to content

build: require edx-lint>=6.2 so make upgrade can run - #1049

Open
irfanuddinahmad wants to merge 1 commit into
openedx:mainfrom
irfanuddinahmad:irfanuddinahmad/edx-lint-6.2-floor
Open

irfanuddinahmad wants to merge 1 commit into
openedx:mainfrom
irfanuddinahmad:irfanuddinahmad/edx-lint-6.2-floor

Conversation

@irfanuddinahmad

@irfanuddinahmad irfanuddinahmad commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Part of openedx/public-engineering#579.

The scheduled Upgrade Requirements job fails at make upgrade with Don't understand 'write_uv_constraints pyproject.toml'. The command first shipped in edx-lint 6.1.0, but uv.lock carried edx-lint 5.6.0 over from the old requirements files, and uv run --with edx-lint reuses the project's installed copy instead of fetching a newer version.

Changes

  • Require edx-lint>=6.2 in the test group (where this repo lists edx-lint; quality includes test) and in the Makefile's uv run --with, matching sample-plugin and fix: require edx-lint>=6.2 so make upgrade can run edx-ace#390. 6.2 also ships the current global constraints.
  • uv lock --upgrade-package edx-lint: edx-lint goes from 5.6.0 to 6.3.1. No other package changes.
  • Regenerate pylintrc with edx_lint write pylintrc. The old file, written by edx-lint 6.1.0, has no [PII] section, and with edx-lint 6.3.1 pylint crashes (astroid-error) on the models modules, which fails the quality env. pylintrc_tweaks is unchanged.

Testing

  • On master, uv run --with edx-lint edx_lint write_uv_constraints pyproject.toml fails with the error above; on this branch, uv run --with 'edx-lint>=6.2' edx_lint write_uv_constraints pyproject.toml succeeds.
  • uv lock --check is clean. quality, pii_check and django52 (1243 passed) pass, run in Docker (python:3.12 with default-libmysqlclient-dev).

When the scheduled job runs after merge, it will also update constraint-dependencies. That is left to the job's own PR.

🤖 Generated with Claude Code

The scheduled Upgrade Requirements job fails at `make upgrade` with
"Don't understand 'write_uv_constraints pyproject.toml'": the lock carried
an edx-lint older than 6.1.0 (where write_uv_constraints first shipped)
over from the old requirements files, and `uv run --with edx-lint` reuses
the project's installed copy instead of fetching a newer one.

Require edx-lint>=6.2 in the quality group and in the Makefile's
`uv run --with`, matching sample-plugin, and run
`uv lock --upgrade-package edx-lint`. 6.2 also ships the current global
constraints.

Regenerate pylintrc with `edx_lint write pylintrc` (edx-lint 6.3.1). The
old file, written by edx-lint 6.1.0, has no [PII] section, and pylint
crashes (astroid-error) on the models modules under edx-lint 6.3.1's PII
checker, failing the quality tox env. pylintrc_tweaks is unchanged.

Part of openedx/public-engineering#579.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Nov 18, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @irfanuddinahmad!

This repository is currently maintained by @openedx/2u-enterprise.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants