Repository navigation
feat(authz): build the roles permission matrix from the catalog - #264
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dcoa/catalog-2-roles-filter #264 +/- ##
===============================================================
+ Coverage 98.62% 98.78% +0.15%
===============================================================
Files 83 84 +1
Lines 1458 1483 +25
Branches 488 485 -3
===============================================================
+ Hits 1438 1465 +27
+ Misses 19 18 -1
+ Partials 1 0 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e69f4d7 to
e84f7d3
Compare
e84f7d3 to
ee7b875
Compare
8b76885 to
41ee384
Compare
41ee384 to
edda083
Compare
| </Popover> | ||
| )} | ||
| > | ||
| <Icon className="d-inline-block text-gray-300 ml-2 my-auto" src={Info} size="sm" /> |
There was a problem hiding this comment.
nit: Not introduced by this pr but keyboard users can't open the category popover. The trigger is a Paragon Icon, which renders a span that can't take focus..The old ResourceTooltip had the same problem, but this is a new component in a PR that claims an accessibility improvement. Feel free to address it on this pr or create a new ticket for it.
There was a problem hiding this comment.
Applied e34fc45 it also darken the icon button to improve contrast
| 'authz.tabs.permissionsRoles.category.other': { | ||
| id: 'authz.tabs.permissionsRoles.category.other', | ||
| defaultMessage: 'Other', | ||
| description: 'Libraries AuthZ name of the category that groups the permissions without a category in the roles table', |
There was a problem hiding this comment.
| description: 'Libraries AuthZ name of the category that groups the permissions without a category in the roles table', | |
| description: 'AuthZ name of the category that groups the permissions without a category in the roles table', |
I like this suggestion but according to the plan this screen will change soon due to the custom roles openedx/openedx-authz#568, so I wont invest more effort on this. |
8520486 to
fc145c0
Compare
The roles and permissions page builds its matrix from the catalog roles, categories and permissions. Co-Authored-By: Claude Opus 5.5 <[email protected]>
fc145c0 to
ee35f5f
Compare
|
🎉 This PR is included in version 1.0.0-alpha.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |


Summary
Build the Roles and Permissions matrix from the AuthZ catalog, replacing the hardcoded course and library definitions.
tbody. It also improve the testing to ensure each permission is displayed in the right category.Evidence
Before: The matrix uses frontend-maintained role and permission definitions that must be synchronized with the backend.
After: The matrix reflects the backend catalog, including role grants, category grouping, and display metadata.
Tests cover scope selection, role ordering, loading and error states, category descriptions, grant indicators, and uncategorized permissions.
Test instructions
With the catalog backend available:
Affects the Roles and Permissions view and its dependency on catalog availability. Requires the catalog infrastructure introduced in #262.
AI disclosure
Code assisted by Claude