Repository navigation
feat(authz): list roles from the catalog in the new roles and permiss… - #285
jacobo-dominguez-wgu wants to merge 2 commits into
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Marked as draft until the api is modified with the filtering, sorting and pagination features and the missing columns are added. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 98.96% 99.05% +0.08%
==========================================
Files 78 88 +10
Lines 1453 1580 +127
Branches 445 485 +40
==========================================
+ Hits 1438 1565 +127
Misses 15 15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8ddf19d to
9d6e732
Compare
Description
The "Roles and Permissions" tab now shows a roles table read from the authz catalog (
GET /api/authz/v1/roles/, ADR 0028), so the client keeps no copy of the roles. It replaces the roles and permissions matrix in that tab.Closes openedx/openedx-authz#568
Changes
definition_kind: "user_defined"show a "Custom Role" sub-label and a pencil (edit) action. Standard roles show an eye (view) action. Every row has a ⋮ menu with "Duplicate" and "Assign role".roles-permissions/components/.roles-permissions/index.ts, andauthz-homeimports it from there.authz-module/index.scss. That rule sets the eye and pencil buttons to--pgn-color-info-500and keeps the primary variant's white icon on hover, because Paragon has no info IconButton variant.Testing
Requires the endpoint modifications of openedx/openedx-authz#623
Go to the Roles and Permissions tab to check for the new table.
RolesPermissionsTable.test.tsx. It covers:Notes for reviewers
RolesPermissions.tsx(the matrix) is no longer rendered, but is kept on purpose for later use.Screenshots / Demos