Repository navigation
feat(authz): assign a role from the roles table row menu - #286
jacobo-dominguez-wgu wants to merge 2 commits into
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## jacobo/roles-table-custom #286 +/- ##
=============================================================
+ Coverage 99.05% 99.07% +0.01%
=============================================================
Files 88 90 +2
Lines 1580 1614 +34
Branches 485 494 +9
=============================================================
+ Hits 1565 1599 +34
Misses 15 15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
93712f7 to
6b5e3c7
Compare
Description
The "Assign role" item in each roles table row menu now opens the assign role wizard with that row's role preselected. It reuses the existing wizard and assignment endpoint; the new work is opening the wizard with a role already selected.
Closes openedx/openedx-authz#570
Changes
useAssignableRoleGroups(inrole-assignation-wizard/hooks/) moves the rules out ofAddRoleButton.AddRoleButtonand the roles table now share it.AddRoleButtonbehaves the same.initialRoleprop onAssignRoleWizard. The role stays changeable and is restored after Cancel.AddRoleButtondoes.RoleAssignmentContext: gives the action cells the assignment state. DataTable keeps the action column's cells from its first render, so a cell factory would hold the permissions from before they finished loading.Testing
Demo
Screen.Recording.2026-11-18.at.11.14.48.AM.mov
Notes for reviewers
jacobo/roles-table-custom, which holds the roles table.