Repository navigation
Conversation
|
Thanks for the pull request, @Lunyachek! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2241 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 368 368
Lines 6019 6026 +7
Branches 1486 1483 -3
=======================================
+ Hits 5788 5795 +7
Misses 222 222
Partials 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Related issue #1038
The two grade bar tooltips on the Progress page render with
show, so Popper positions them once, on mount — while the grades are still loading. By the time the page finishes, the bubbles sit next to the bar instead of on it. Scrolling fixes it, because scrolling is one of the few things Popper listens for.It listens for scroll and window resize, but not for the page growing underneath it. So this adds a
ResizeObserveron<body>and remounts the two tooltips when it fires, which makes Popper measure again. A plain re-render isn't enough —usePopperonly callssetOptionswhen placement or strategy change, and neither does here.The issue is filed as RTL, though the text direction has nothing to do with it - I ran into this in English first. The screenshots are RTL to match the issue.
How to test
Before fix:
After fix: