Skip to content

fix: reposition progress grade bar tooltips on initial render - #2241

Open
Lunyachek wants to merge 2 commits into
openedx:masterfrom
raccoongang:lunyachek/fix/grade-bar-tooltip-initial-position
Open

Lunyachek wants to merge 2 commits into
openedx:masterfrom
raccoongang:lunyachek/fix/grade-bar-tooltip-initial-position

Conversation

@Lunyachek

Copy link
Copy Markdown
Contributor

Related issue #1038

The two grade bar tooltips on the Progress page render with show, so Popper positions them once, on mount — while the grades are still loading. By the time the page finishes, the bubbles sit next to the bar instead of on it. Scrolling fixes it, because scrolling is one of the few things Popper listens for.

It listens for scroll and window resize, but not for the page growing underneath it. So this adds a ResizeObserver on <body> and remounts the two tooltips when it fires, which makes Popper measure again. A plain re-render isn't enough —
usePopper only calls setOptions when placement or strategy change, and neither does here.

The issue is filed as RTL, though the text direction has nothing to do with it - I ran into this in English first. The screenshots are RTL to match the issue.

How to test

  1. Enroll in a course, open the Progress tab.
  2. Hard-reload and look at the grade bar before touching the page.
  3. Before: the % bubbles float off the bar. After: they're on it.

Before fix:

Снимок экрана 2026-11-09 в 00 01 26 Снимок экрана 2026-11-09 в 00 01 52

After fix:

Снимок экрана 2026-11-08 в 23 56 58 Снимок экрана 2026-11-08 в 23 57 44

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 8, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Lunyachek!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov

codecov Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.16%. Comparing base (230799e) to head (4c7195f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2241   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files         368      368           
  Lines        6019     6026    +7     
  Branches     1486     1483    -3     
=======================================
+ Hits         5788     5795    +7     
  Misses        222      222           
  Partials        9        9           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arbrandes
arbrandes removed their request for review November 16, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants