Repository navigation
docs: add ADR proposing to reference course scopes by course key - #625
mariajgrimaldi wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @mariajgrimaldi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
4f9d95a to
e858d65
Compare
Co-Authored-By: Claude Opus 5.5 <[email protected]>
e858d65 to
abbef90
Compare
Description
Migration
0007_coursescopefails with MySQL error 3780 when the platform's course table doesn't useutf8mb4_unicode_ci(#593). #626 fixes the migration, but the foreign key fromCourseScopeto the platform'sCourseOverviewstays, and with it a dependency on how openedx-platform models courses, although course scopes already store their course key inScope.external_key.ADR 0035 proposes referencing course scopes only by that key, with a read-only
course_overviewproperty, apost_deletereceiver that deletes the scope and its role assignments with the course, and a migration that copies older keys intoexternal_keyand removes the column, which #627 implements. Content library scopes keep their foreign key, and a dated addendum to ADR 0005 points to the new ADR.Related to #593.
Testing instructions
Docs only, rendered in ADR 0035 on Read the Docs.
Merge checklist:
Check off if complete or not applicable: