Repository navigation
Conversation
|
Thanks for the pull request, @BryanttV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
48b0920 to
c4de3ce
Compare
5d546a8 to
36e67a8
Compare
20004c8 to
9688e7f
Compare
Align course categories and permissions with the product proposal for the Roles and Permissions console: move View course info, View checklists, Export tags and the group configuration permissions to their new groups, remove the empty course_information and course_other categories, rename and re-describe groups, and hide manage_taxonomies. Role grants and permission checks are unchanged. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
9688e7f to
fa49f50
Compare
Description
The course permission categories and permissions did not match the product proposal for the Roles and Permissions console. Some permissions lived in categories where users would not look for them, two categories were nearly empty, and several descriptions did not say where the permission applies. This PR aligns the schema with the proposal. It only changes catalog metadata: role grants and permission checks are unchanged.
courses.view_course_infoandcourses.view_checklists→course_access_content("Course access & content").courses.export_tags→course_tags_taxonomies("Tags").courses.view_group_configurationsandcourses.manage_group_configurations→course_cohorts_content_groups("Cohorts & content groups").course_informationandcourse_othercategories, which are now empty.course_grading→course_grading_settings: "Grading" → "Grading settings".course_team_group→course_team: "Course team & groups" → "Course team".course_cohorts→course_cohorts_content_groups: "Cohorts" → "Cohorts & content groups".course_advanced_certificates→course_advanced_settings_certificates: "Advanced & certificates" → "Advanced settings & certificates".course_import_export: "Import/export" → "Course import & export" (ID unchanged).courses.manage_taxonomiesashidden, using the flag from feat: add hidden property to permission categories and permissions #634. The permission is still granted tocourse_adminbut no longer appears in the catalog.docs/references/compiled-schema.yamland adds aCHANGELOG.rstentry.Affected roles: none for access. The role and permission catalog in the Roles and Permissions console shows the new grouping, names, and descriptions to Operators and Course Admins.
Supporting Information
Testing Instructions
Check out this branch and install the dependencies:
Run the schema and catalog tests:
Expected: all tests pass.
Regenerate the compiled schema and confirm it is in sync with the YAML sources:
Expected: no diff.
Load the schema and list the course categories and permissions through the catalog API (for example, with
python manage.py shellafter the schema is applied). Verify that:course_information,course_other,course_cohorts,course_team_group, andcourse_gradingno longer exist.course_cohorts_content_groups,course_team,course_grading_settings, andcourse_advanced_settings_certificatesexist and contain the same permissions as the categories they replace.view_course_infoandview_checklistsare incourse_access_content,export_tagsis incourse_tags_taxonomies, and the two group configuration permissions are incourse_cohorts_content_groups.courses.manage_taxonomiesis not listed in the catalog or in thecourse_adminrole's permission list.Verify nothing changed for access. A user with the
course_adminrole still passes thecourses.manage_taxonomiespermission check, and the other course roles still pass the same checks as before.Deadline
Willow
Other Information
course_informationandcourse_otherare deleted, andcourse_cohorts,course_team_group, andcourse_gradingbecomecourse_cohorts_content_groups,course_team, andcourse_grading_settings. When the schema is applied, the old categories are pruned, and the permissions are re-linked to the new ones, so no data migration is needed. Nothing in this repository references the old IDs, but consumers that read category IDs from the catalog API (such as the Roles and Permissions console frontend) must use the new ones.