Skip to content

cleanup: delete orphaned xmodule/js/src/html/display.js and imageModal.js #38792

Open

Description

@irfanuddinahmad

Context

As part of the Slash-n-Burn Built-In XBlocks epic:

After both PRs merge, neither of these files is referenced by any webpack entry:

  • xmodule/js/src/html/display.js
  • xmodule/js/src/html/imageModal.js

They cannot be deleted in PR #38748 before PR #38746 merges (they are still referenced by AnnotatableBlockDisplay in webpack.builtinblocks.config.js on master), so this follow-up issue tracks the cleanup.

Work to do

Once both PR #38746 and PR #38748 are merged into master:

  1. Delete xmodule/js/src/html/display.js
  2. Delete xmodule/js/src/html/imageModal.js
  3. Remove the draggabilly.js imports-loader rule from webpack.common.config.js (line ~317) if no other entry references xmodule/js/common_static/js/vendor/draggabilly.js

This is a small standalone PR — should take ~5 minutes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions