You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
cleanup: delete orphaned xmodule/js/src/html/display.js and imageModal.js #38792
PR refactor: slash-and-burn Annotatable BuiltIn XBlock #38746 removes the Annotatable block, which deletes the webpack entry AnnotatableBlockDisplay — the entry that previously included xmodule/js/src/html/display.js alongside the annotatable display JS.
After both PRs merge, neither of these files is referenced by any webpack entry:
xmodule/js/src/html/display.js
xmodule/js/src/html/imageModal.js
They cannot be deleted in PR #38748 before PR #38746 merges (they are still referenced by AnnotatableBlockDisplay in webpack.builtinblocks.config.js on master), so this follow-up issue tracks the cleanup.
Work to do
Once both PR #38746 and PR #38748 are merged into master:
Delete xmodule/js/src/html/display.js
Delete xmodule/js/src/html/imageModal.js
Remove the draggabilly.js imports-loader rule from webpack.common.config.js (line ~317) if no other entry references xmodule/js/common_static/js/vendor/draggabilly.js
This is a small standalone PR — should take ~5 minutes.
Activity