You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Require an active account on the conforming authoring API viewsets #39357
ADR 0034 (docs/decisions/0034-unify-auth-oauth2-dot-v2.rst) says new endpoints take the platform default authentication classes unless there is a reason to deviate, and names SessionAuthenticationAllowInactiveUser as a deviation that has to be commented. The conforming authoring viewsets added under #38137 all carry that deviation so that an account that has not been activated yet can still use Studio from a fresh session. We've had mixed opinions over the years on whether an un-activated account should be able to do things in Studio. I'd like to standardize on requiring an active account for the authoring APIs, which is what #39229 already does for the course outline and what I've asked for on #39227 for grading.
Description
Today these viewsets set authentication_classes = (JwtAuthentication, SessionAuthenticationAllowInactiveUser) with a comment explaining the deviation:
Change: remove the authentication_classes line and its comment from each so the platform default applies, update the ADR 0034 note in each module docstring, and add a test per viewset that a session for an inactive account gets a 401. A JWT for an inactive account is not checked for activation under the platform default either, so JWT callers do not change.
Out of scope, preserved: the v0 and v1 endpoints these supersede keep their view_auth_classes decorator until they are removed under their DEPR entries. Nothing changes for active accounts.
Activity
feanil commentedon Nov 9, 2026
@taimoor-ahmed-1 @Faraz32123 What do you think about this?