Repository navigation
refactor: slash-and-burn Word Cloud BuiltIn XBlock #38745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
cdf9547
f28a5b8
3c2e7a8
4f87536
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -2112,14 +2112,6 @@ def add_optional_apps(optional_apps, installed_apps): | |||
| # | ||||
| # Ticket: https://github.com/openedx/edx-platform/issues/35308 | ||||
|
|
||||
| # .. toggle_name: USE_EXTRACTED_WORD_CLOUD_BLOCK | ||||
| # .. toggle_default: True | ||||
| # .. toggle_implementation: DjangoSetting | ||||
| # .. toggle_description: Enables the use of the extracted Word Cloud XBlock, which has been shifted to the 'openedx/xblocks-core' repo. | ||||
| # .. toggle_use_cases: temporary | ||||
| # .. toggle_creation_date: 2024-11-10 | ||||
| # .. toggle_target_removal_date: 2026-04-10 | ||||
| USE_EXTRACTED_WORD_CLOUD_BLOCK = True | ||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Verawood dev/op notes announced this removal for Willow. Add it under Deprecations & Removals in Willow dev/op notes, or confirm one entry covers all 8 blocks: * **Removed the built-in Word Cloud block.** ``xmodule.word_cloud_block`` and the
``USE_EXTRACTED_WORD_CLOUD_BLOCK`` setting are removed. The Word Cloud block from
`xblocks-core <https://github.com/openedx/xblocks-core>`_ is always used. |
||||
|
|
||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: double blank line.
Suggested change
|
||||
| # .. toggle_name: USE_EXTRACTED_ANNOTATABLE_BLOCK | ||||
| # .. toggle_default: True | ||||
|
|
||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -464,7 +464,7 @@ vertical = "xmodule.vertical_block:VerticalBlock" | |
| video = "xmodule.video_block:VideoBlock" | ||
| videoalpha = "xmodule.video_block:VideoBlock" | ||
| videodev = "xmodule.template_block:TranslateCustomTagBlock" | ||
| word_cloud = "xmodule.word_cloud_block:WordCloudBlock" | ||
| word_cloud = "xblock_word_cloud:WordCloudBlock" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update the "Remove the entrypoint" item in openedx/public-engineering#534 to say re-pointed, and list this under a "Changed" heading in the PR description. |
||
| wrapper = "xmodule.wrapper_block:WrapperBlock" | ||
|
|
||
| [project.entry-points."xblock_asides.v1"] | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -304,15 +304,7 @@ module.exports = Merge.merge({ | |||
| * we know, the only modules that absolutely need to be added to the global namespace are those | ||||
| * which define module types, for example "Problem" (in xmodule/js/src/capa/display.js). | ||||
| */ | ||||
| { | ||||
| test: /xmodule\/assets\/word_cloud\/src\/js\/word_cloud.js/, | ||||
| use: [ | ||||
| { | ||||
| loader: 'imports-loader', | ||||
| options: 'this=>window' | ||||
| } | ||||
| ] | ||||
| }, | ||||
|
|
||||
| { | ||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: leftover blank line.
Suggested change
|
||||
| test: /xmodule\/js\/common_static\/js\/vendor\/draggabilly.js/, | ||||
| use: [ | ||||
|
|
@@ -629,7 +621,6 @@ module.exports = Merge.merge({ | |||
| 'lms/static', | ||||
| path.resolve(__dirname), | ||||
| 'xmodule/js/src', | ||||
| 'xmodule/assets/word_cloud/src/js', | ||||
| 'common/static', | ||||
| 'common/static/coffee/src', | ||||
| 'common/static/common/js', | ||||
|
|
||||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit (optional): only one subclass is left, and the cache reset was only needed for the removed
importlib.reload: