Repository navigation
refactor: remove built-in LTI XBlock implementation (slash-n-burn #37819) - #38747
irfanuddinahmad wants to merge 7 commits into
Conversation
|
Thanks for the pull request, @irfanuddinahmad! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
7eb55b9 to
6a680a4
Compare
3885169 to
0da9a28
Compare
0da9a28 to
9ebb7e9
Compare
9ebb7e9 to
f690abf
Compare
) Removes xmodule/lti_block.py, xmodule/lti_2_util.py, all LTI JS/CSS/template assets, webpack entries, the USE_EXTRACTED_LTI_BLOCK toggle, and the conflicting `lti` entrypoint in pyproject.toml now that the extracted version in xblocks-contrib is the only implementation. Collapses toggle-conditional test classes into single test classes targeting the extracted-block behavior. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
The built-in LTI block modules no longer exist, so these allowlist entries cannot be imported and fail test_default_allowlist_entries_import. The xblocks_contrib.lti equivalents remain on the allowlist. Co-Authored-By: Claude Opus 5.5 <[email protected]>
xblocks-core 2.0.0 (#38473) removed the xblocks_contrib package. Point the platform entrypoint, imports and mock.patch targets at the new per-block packages (e.g. xblocks_contrib.video.video -> xblock_video.block). Co-Authored-By: Claude Opus 5.5 <[email protected]>
f690abf to
db8b616
Compare
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Summary
Removes the built-in LTI XBlock.
xblock_lti.LTIBlockhas been the default sinceUSE_EXTRACTED_LTI_BLOCK = True, so the built-in code no longer runs.Part of the Slash-n-Burn Built-In XBlocks epic. Closes openedx/public-engineering#537
Changes
Deleted:
xmodule/lti_block.py(built-in class + shim),xmodule/lti_2_util.py(nowxblock_lti.lti_2_util),xmodule/js/src/lti/lti.js,xmodule/js/fixtures/lti.html,LTIBlockDisplay.css,lms/templates/lti.htmlandlti_form.html, theLTIBlockDisplay/LTIBlockEditorwebpack entries and theimports-loaderrule forlti/lti.js, the built-inltientrypoint, and theUSE_EXTRACTED_LTI_BLOCKtoggle.Modified:
lms/envs/common.pydrops the two built-in LTI handlers fromXBLOCK_NOAUTH_HANDLER_ALLOWLIST. They can no longer be imported, which would failtest_default_allowlist_entries_import; thexblock_ltientries stay on the list.Tests:
xmodule/tests/test_lti_unit.py,test_lti20_unit.py(43 tests)src/xblock_lti/tests/: same names, near-identical bodies (compared one by one)Kept in the platform:
lms/djangoapps/courseware/tests/test_lti_integration.py: toggle branches collapsed to the extracted path, BuiltIn twin classes andimportlib.reload(lti_block)dropped.lms/djangoapps/courseware/tests/test_block_render.py: imports fromxblock_lti.Epic Step 1: Post-extraction commit review
Toggle flipped 2026-02-02 (
bcddf9cd53). All 5 later commits tolti_block.py/lti_2_util.pyare cosmetic (deprecation markers #38174, ruff suppression, style, import sorting, lint-amnesty). The one pre-toggle fix, a Library v2 preview fix (cc56e41d0c), is already in xblocks-core ("fix: fix LTI XBlock preview in Content Library"). Nothing to port.Test plan
Tested on a local Tutor nightly (master
6f85d63c7f+ xblocks-core 2.0.0) through the REST APIs and a headless browser, because PR sandboxes aren't deploying (open-craft/pr-sandbox-automation#28). A box is ticked only if that flow actually ran.XBLOCK_NOAUTH_HANDLER_ALLOWLISTerrors in the logspytest lms/djangoapps/courseware/tests/test_lti_integration.py(5 passed locally) andtest_block_render.py(166 passed),npm run build; theltientrypoint resolves toxblock_lti:LTIBlockV2 Library checklist: 11/12 pass (L10 export diff not done)
Content Libraries V2: smoke tests (historically the most fragile area for extracted blocks: openedx/xblocks-core#123, openedx/xblocks-core#132, openedx/xblocks-core#243, openedx/xblocks-core#274)
LTI-specific:
XBLOCK_NOAUTH_HANDLER_ALLOWLISTerrors in the logsLibrary checklist compiled from the Aximprovements manual test doc (Extracted Block Tests tab) and the Ulmo test sheet's library cases. Generated using Claude Code.
Screenshots
5 screenshots (LMS, Studio unit, V2 Library)
Local Tutor nightly, 2026-11-12
Captured automatically during the local smoke tests (the sandbox isn't reachable yet, see open-craft/pr-sandbox-automation#28). All images: irfanuddinahmad/edx-platform@snb-smoke-screenshots/38747.
🤖 Generated with Claude Code
Settings