Repository navigation
build: drop the django42 test dependency group - #39374
Merged
Merged
Conversation
Nothing in CI selects it: migrations-check.yml and unit-tests.yml only run django-version "pinned", which resolves Django through the testing group's own Django<6.0 constraint (5.2.x today). The group's only effect was on uv.lock, where the django42/django52 conflict set forced a second resolution for every package whose newest release no longer supports Django 4.2. lti-consumer-xblock 11.5.0 (django>=5.2) was the latest: the 2026-11-13 requirements bump (openedx#39373) locked 11.4.4 for django42 and 11.5.0 for everything else. Removing the group and the [tool.uv].conflicts entry collapses those packages to the version the pinned environment already installs (django, django-autocomplete-light, django-filter, django-ipware, django-simple-history, edx-auth-backends, event-tracking, lti-consumer-xblock); no package in the pinned set changes version. The django52 group stays for a future explicit-version matrix leg. Co-Authored-By: Claude Fable 5.1 <[email protected]>
feanil
marked this pull request as ready for review
November 13, 2026 20:52
UsamaSadiq
approved these changes
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the
django42dependency group and empties the[tool.uv].conflictsset that paired it withdjango52, leaving a note on how to repopulate it when two Django versions are tested at once.Nothing in CI selects the group:
migrations-check.ymlandunit-tests.ymlonly rundjango-version: "pinned", which resolves Django through thetestinggroup's ownDjango<6.0constraint. The group's only effect was onuv.lock, where the conflict set forced a second resolution for every package whose newest release has dropped Django 4.2.lti-consumer-xblock11.5.0 (django>=5.2) was the latest one: #39373 locked 11.4.4 fordjango42and 11.5.0 for everything else, and the bot's summary listed the package four times.With the group gone, eight packages collapse to the single version the pinned environment already installs:
django,django-autocomplete-light,django-filter,django-ipware,django-simple-history,edx-auth-backends,event-tracking,lti-consumer-xblock. No package in the pinned set changes version;uv lock --checkis clean.Preserved: the
django52group, for a future explicit-version matrix leg, and the bareDjangoruntime requirement with its<6.0constraint. This changes what we test, not what the platform declares it runs on.