Skip to content

fix: pin pypa/gh-action-pypi-publish to a commit SHA - #280

Merged
farhan merged 2 commits into
openedx:mainfrom
irfanuddinahmad:irfanuddinahmad/pin-pypi-publish-sha
Nov 13, 2026
Merged

farhan merged 2 commits into
openedx:mainfrom
irfanuddinahmad:irfanuddinahmad/pin-pypi-publish-sha

Conversation

@irfanuddinahmad

@irfanuddinahmad irfanuddinahmad commented Jul 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Pin pypa/gh-action-pypi-publish to a commit SHA (was @release/v1, a floating branch ref).

Why

Your release run on 2026-07-14 failed with docker: manifest unknown: https://github.com/openedx/xblocks-core/actions/runs/29327012856/job/87066591905

@release/v1 is a floating branch, not a version tag -- it resolved to a commit whose Docker image wasn't yet published on ghcr.io at the moment this workflow ran (a race between the branch moving and the image being built). The next release run happened to succeed once the image caught up, but the underlying race is still there and will fail unpredictably again on a future release.

This traces back to openedx/sample-plugin's release.yml (the reference implementation for the org-wide Python tooling modernization effort), which has the same unpinned ref -- fixed there in openedx/sample-plugin#54.

Test plan

  • YAML is unchanged apart from the one uses: line; no functional change to the workflow's logic.
  • SHA 7245906fb61fa33a13554f9d5fb856fe61758086 is v1.14.3, the latest release and the current tip of pypa/gh-action-pypi-publish's release/v1 branch (checked 2026-11-13). It matches the pin merged in fix: pin pypa/gh-action-pypi-publish to a commit SHA sample-plugin#54.

🤖 Generated with Claude Code

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jul 15, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @irfanuddinahmad!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211

Copy link
Copy Markdown

Hi @irfanuddinahmad! Just flagging a failing check here.

@release/v1 is a floating branch ref, not a version tag. Your release run
on 2026-07-14 failed with "docker: manifest unknown" because that ref
resolved to a commit whose Docker image wasn't published on ghcr.io yet
(https://github.com/openedx/xblocks-core/actions/runs/29327012856/job/87066591905).
The following run happened to succeed once the image caught up, but the
underlying race is still there and will fail unpredictably again.

Pin to the exact commit backing the current v1.14.0 release instead,
consistent with how the rest of this workflow's actions are already pinned.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
@irfanuddinahmad
irfanuddinahmad force-pushed the irfanuddinahmad/pin-pypi-publish-sha branch from 96ead1b to c7e41f5 Compare October 7, 2026 05:09
@mphilbrick211 mphilbrick211 moved this from Waiting on Author to Ready for Review in Contributions Nov 4, 2026
@mphilbrick211 mphilbrick211 moved this from Ready for Review to Ready to Merge in Contributions Nov 4, 2026
@mphilbrick211

Copy link
Copy Markdown

Hi @openedx/axim-engineering! Could someone take a look at this for us?

@farhan

farhan commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

@irfanuddinahmad Thanks for this! Could you bump the pin to the latest release, v1.14.3? That keeps it in sync with what openedx/sample-plugin#54 merged.

.github/workflows/release.yml:117

        uses: pypa/gh-action-pypi-publish@7245906fb61fa33a13554f9d5fb856fe61758086 # v1.14.3

Also, please update the PR description: v1.14.0 is no longer the tip of release/v1. Once that's done, I'll merge it.

@irfanuddinahmad

Copy link
Copy Markdown
Contributor Author

@farhan done: the pin is now 7245906fb61fa33a13554f9d5fb856fe61758086 # v1.14.3 (44e6d5d), matching sample-plugin. I've also updated the description to match.

@farhan
farhan merged commit 958b119 into openedx:main Nov 13, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to Merge to Done in Contributions Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants