Repository navigation
fix: pin pypa/gh-action-pypi-publish to a commit SHA - #280
Conversation
|
Thanks for the pull request, @irfanuddinahmad! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @irfanuddinahmad! Just flagging a failing check here. |
@release/v1 is a floating branch ref, not a version tag. Your release run on 2026-07-14 failed with "docker: manifest unknown" because that ref resolved to a commit whose Docker image wasn't published on ghcr.io yet (https://github.com/openedx/xblocks-core/actions/runs/29327012856/job/87066591905). The following run happened to succeed once the image caught up, but the underlying race is still there and will fail unpredictably again. Pin to the exact commit backing the current v1.14.0 release instead, consistent with how the rest of this workflow's actions are already pinned. Co-Authored-By: Claude Sonnet 5 <[email protected]>
96ead1b to
c7e41f5
Compare
|
Hi @openedx/axim-engineering! Could someone take a look at this for us? |
|
@irfanuddinahmad Thanks for this! Could you bump the pin to the latest release, v1.14.3? That keeps it in sync with what openedx/sample-plugin#54 merged.
uses: pypa/gh-action-pypi-publish@7245906fb61fa33a13554f9d5fb856fe61758086 # v1.14.3Also, please update the PR description: v1.14.0 is no longer the tip of |
Matches the pin merged in openedx/sample-plugin#54. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Summary
Pin
pypa/gh-action-pypi-publishto a commit SHA (was@release/v1, a floating branch ref).Why
Your release run on 2026-07-14 failed with
docker: manifest unknown: https://github.com/openedx/xblocks-core/actions/runs/29327012856/job/87066591905@release/v1is a floating branch, not a version tag -- it resolved to a commit whose Docker image wasn't yet published on ghcr.io at the moment this workflow ran (a race between the branch moving and the image being built). The next release run happened to succeed once the image caught up, but the underlying race is still there and will fail unpredictably again on a future release.This traces back to
openedx/sample-plugin'srelease.yml(the reference implementation for the org-wide Python tooling modernization effort), which has the same unpinned ref -- fixed there in openedx/sample-plugin#54.Test plan
uses:line; no functional change to the workflow's logic.7245906fb61fa33a13554f9d5fb856fe61758086isv1.14.3, the latest release and the current tip ofpypa/gh-action-pypi-publish'srelease/v1branch (checked 2026-11-13). It matches the pin merged in fix: pin pypa/gh-action-pypi-publish to a commit SHA sample-plugin#54.🤖 Generated with Claude Code