Repository navigation
Conversation
|
Thanks for the pull request, @bra-i-am! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
4f512f6 to
abe1926
Compare
4bc009e to
bd54078
Compare
Summary
Fixes Submit remaining enabled after Reset on CAPA problems.
render()andbind()correctly disable Submit for the empty reset inputs. The request's.always()handler indisableAllButtonsWhileRunning()then restores the initially enabled buttons, re-enabling Submit. The animation-frame callback recalculates the answer state after that handler completes.Adds regression tests for radio buttons and checkboxes, including re-enabling Submit when another answer is selected.
Closes openedx/openedx-platform#36824
Manual testing
Screencasts
Screencast.from.17-09-26.15.39.26.webm
Screencast.from.17-09-26.15.39.02.webm
Merge Danger
Door: Two-way — reversible JavaScript change; no data migration.
Blast Radius: CAPA — Submit state after a successful problem reset.