Skip to content

fix: add animation frame for submitting answers after problem reset - #303

Open
bra-i-am wants to merge 3 commits into
openedx:mainfrom
eduNEXT:bc/fix-issue-36824
Open

bra-i-am wants to merge 3 commits into
openedx:mainfrom
eduNEXT:bc/fix-issue-36824

Conversation

@bra-i-am

@bra-i-am bra-i-am commented Sep 17, 2026 •

Copy link
Copy Markdown

Summary

Fixes Submit remaining enabled after Reset on CAPA problems.

render() and bind() correctly disable Submit for the empty reset inputs. The request's .always() handler in disableAllButtonsWhileRunning() then restores the initially enabled buttons, re-enabling Submit. The animation-frame callback recalculates the answer state after that handler completes.

Reset response
  render/bind → disable Submit for empty answers
  request completion → restore initially enabled buttons
  animation-frame callback → recalculate Submit from the reset answers

Adds regression tests for radio buttons and checkboxes, including re-enabling Submit when another answer is selected.

Closes openedx/openedx-platform#36824

Manual testing

  1. Use a Tutor environment with this package installed as editable, switch to this branch, and rebuild the problem assets.
  2. Open a Single Choice (SCQ) or Multiple Choice (MCQ) problem with Reset available.
  3. Select an incorrect answer and submit it.
  4. Click Reset. Confirm the selections clear and Submit is disabled.
  5. Select another answer. Confirm Submit becomes enabled.

Screencasts

Before After
Screencast.from.17-09-26.15.39.26.webm
Screencast.from.17-09-26.15.39.02.webm

Merge Danger

Door: Two-way — reversible JavaScript change; no data migration.

Blast Radius: CAPA — Submit state after a successful problem reset.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 17, 2026
@openedx-webhooks

openedx-webhooks commented Sep 17, 2026 •

Copy link
Copy Markdown

Thanks for the pull request, @bra-i-am!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

[Test failure] <TC_AUTHOR_50>: <Reset option is not working properly for submit button in common problem components>

2 participants